Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visualize topologies before finding solutions #28

Closed
redeboer opened this issue Oct 27, 2020 · 0 comments · Fixed by #86
Closed

Visualize topologies before finding solutions #28

redeboer opened this issue Oct 27, 2020 · 0 comments · Fixed by #86
Assignees
@redeboer
Labels
📝 Docs Improvements or additions to documentation ✨ Feature New feature added to the package
Milestone
0.9.2

Comments

@redeboer
Copy link
Member

While trying to generate a 4-body decay with the isobar model (for #27), I found it would be nice to inspect the generated Topology instances (so the uninitialized ones) prior to running StateTransitionManager.find_solutions, because find_solutions may take a long time and you want to check if those topologies make sense.

See also ComPWA/expertsystem#342
@redeboer redeboer transferred this issue from ComPWA/expertsystem Apr 6, 2021
@redeboer redeboer added the ✨ Feature New feature added to the package label Apr 16, 2021
@redeboer redeboer added the 📝 Docs Improvements or additions to documentation label May 27, 2021
@redeboer redeboer added this to the 0.9.1 milestone May 27, 2021
@redeboer redeboer self-assigned this May 27, 2021
@redeboer redeboer modified the milestones: 0.9.1, 0.9.2 Jul 21, 2021
@redeboer redeboer mentioned this issue Jul 21, 2021
Merged
@redeboer redeboer modified the milestones: 0.9.3, 0.9.2a Jul 26, 2021
redeboer pushed a commit to redeboer/ComPWA-qrules that referenced this issue Apr 30, 2022
@spflueger @redeboer
refactor!: improve for the ComPWA python UI (ComPWA#28)
692de0b 
Now it is possible to easily create ComPWA compatible data using
python. This means ComPWA Particle, Event and DataPoint structures can
now be created (Fixes ComPWA#30). Furthermore the HelicityKinematics
`convert()` method is now available in the python UI. The documentation
for importing data was also improved.

* Extended the Event, Particle and DataPoint structure in the python
  UI.
* Also made these classes more pythonic, so their members are read only
  properties.
* Added docstrings to the necessary members.
* Updated ComPWA submodule to newest version. This resulted in removing
  the gsl dependency.
* Adapted a test to the PreFactor change coming from ComPWA. There the
  PreFactor is now part of the CoefficientAmplitude and not the
  SequentialAmplitude.
* The read and write section in the docs was improved.
* A new jupyter notebook was added to the examples section. This
  example also appears in the docs.
redeboer added a commit to redeboer/ComPWA-qrules that referenced this issue Apr 30, 2022
@redeboer
ci: add pydocstyle check (ComPWA#28)
a102c62 
* ci: set requirements to minimal, not exact
* ci: add pydocstyle checks
* ci: ignore pydocstyle D203
* ci: ignore pydocstyle D212
PyCQA/pydocstyle#242 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@redeboer redeboer

Labels
📝 Docs Improvements or additions to documentation ✨ Feature New feature added to the package
Projects
None yet
Milestone
0.9.2
Development

Successfully merging a pull request may close this issue.

feat: render ProblemSet as DOT ComPWA/qrules
1 participant
@redeboer