Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formulate graph settings in terms of classes #21

Open
redeboer opened this issue Sep 23, 2020 · 1 comment
Open

Formulate graph settings in terms of classes #21

redeboer opened this issue Sep 23, 2020 · 1 comment
Labels
🔨 Maintenance Maintenance and upkeep improvements

Comments

@redeboer
Copy link
Member

The StateTransitionManager.prepare_graphs method returns a structure that is not transparent and prone to errors once the user modifies it and plugs into find_solutions. (Modification is actually the reason why it is returned separately first, see Quickstart 1.2.

The type hints that we use for these functions already indicate that some proper class structure would be better here:
https://github.com/ComPWA/expertsystem/blob/22fb207f8ee1e2d409ef31734f4839ae12778819/expertsystem/ui/_system_control.py#L37-L39
@spflueger
Copy link
Member

This is partially solved by PR ComPWA/expertsystem#278

@redeboer redeboer transferred this issue from ComPWA/expertsystem Apr 6, 2021
@redeboer redeboer added the 🔨 Maintenance Maintenance and upkeep improvements label Apr 16, 2021
redeboer added a commit to redeboer/ComPWA-qrules that referenced this issue Apr 30, 2022
@redeboer
test: clean up tests folder (ComPWA#21)
8b19d94 
* ci: set skip imports for mypy
* chore: add gitignore to tests folder
* test: remove disabled tests
* test: move non-tests to examples
* test: reorganise tests folder
* test: simiplify pytest.ini
* test: add more `pytest.mark.slow` markers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🔨 Maintenance Maintenance and upkeep improvements
Projects
Student projects
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spflueger @redeboer