ENH: use Fraction for spin values
#288
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redeboer
added
the
⚙️ Enhancement
redeboer
reviewed
Oct 8, 2024
| else: | ||
| p.pretty(value) # type: ignore[attr-defined] | ||
| p.text(",") | ||
| p.breakable() | ||
| p.text(")") | ||
|
|
||
|
|
||
| def _float_as_signed_fraction_str(value: float, render_plus: bool = False) -> str: |
There was a problem hiding this comment.
I was curious why there is a cast to Fraction. Maybe a doctest would be useful:
Suggested change
| def _float_as_signed_fraction_str(value: float, render_plus: bool = False) -> str: | |
| def _float_as_signed_fraction_str(value: float, render_plus: bool = False) -> str: | |
| """Convert a float to a fraction string with optional sign. | |
| >>> _float_as_signed_fraction_str(1.5) | |
| '3/2' | |
| >>> _float_as_signed_fraction_str(-1.5) | |
| '-3/2' | |
| """ |
redeboer
changed the title
Spin class to have magnitude & projection as FractionsFraction for spin values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
Spinclass would have the types of its fieldsmagnitude&projectionto be ofthe
Fraction-type, it would simplyfy the validation of their values (multiples of 1/2,projection <= magnitude, etc.)