Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate linting in Jupyter Lab through LSP #165

Closed
16 tasks done
redeboer opened this issue Aug 22, 2023 · 0 comments · Fixed by #229, ComPWA/qrules#238, ComPWA/ampform#369, ComPWA/ampform-dpd#87 or ComPWA/tensorwaves#508
Closed
16 tasks done
Assignees
Labels
🖱️ DX Improvements to the Developer Experience

Comments

@redeboer
Copy link
Member

redeboer commented Aug 22, 2023

Linting, formatting and language navigation can be made available through jupyterlab-lsp and python-lsp-server (not Jedi). Additional support for (3rd party) linters like Ruff can be found there as well.

It might even be possible to replace jupyterlab-code-formatter with python-lsp-black. Even MyPy can be supported through pylsp-mypy.

In first instance:

python3 -m pip install jupyterlab-lsp
python3 -m pip install python-lsp-server[rope]

Then optionally for formatting:

python3 -m pip install python-lsp-black

And linting with Ruff:

python3 -m pip install python-lsp-ruff

Best to wait until jupyterlab-lsp v5 for its support for Jupyter Lab v4
https://github.com/jupyter-lsp/jupyterlab-lsp/releases

Implementation

  1. 🖱️ DX
    redeboer
  2. 🖱️ DX
    redeboer
  3. 🖱️ DX
    redeboer
  4. 🖱️ DX
    redeboer
  5. 🖱️ DX
    redeboer
  6. 🖱️ DX
    redeboer
  7. 🖱️ DX
    redeboer

Implementation PRs

  1. 🖱️ DX
    redeboer
  2. 🖱️ DX
    redeboer
  3. 🖱️ DX
    redeboer
  4. 🖱️ DX
    redeboer
  5. 🖱️ DX
    redeboer
  6. 🖱️ DX
    redeboer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment