Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace flake8, isort, pydocstyle, and pylint with Ruff #138

Closed
12 tasks done
Tracked by #98
redeboer opened this issue May 30, 2023 · 0 comments · Fixed by #145, ComPWA/qrules#222, ComPWA/ampform#354, ComPWA/ampform-dpd#76 or ComPWA/tensorwaves#492
Closed
12 tasks done
Tracked by #98
Assignees
Labels
🖱️ DX Improvements to the Developer Experience

Comments

@redeboer
Copy link
Member

redeboer commented May 30, 2023

See https://github.com/charliermarsh/ruff and its VSCode extension. Seems to be used by an increasing number of repositories. Might be nice to replace Pylint, which is way too slow in most ComPWA repositories.

Major advantages:

  • Extremely fast
  • All linters contained in one (greatly reduces dependencies as well as the .pre-commit-config.yaml)
  • Perfect autofix integration through both VSCode as well as pre-commit
  • Quickly add noqa statements from VSCode with Quick fix (Ctrl+.). Hovering over the added ignored code shows more info about that error code.
  • Great error code documentation
  • Simplifies Merge developer configurations into pyproject.toml #98

Disadvantage for now: the package marks itself as beta, see e.g. its website URL beta.ruff.rs.

Implementation PRs

  1. 🔨 Maintenance
    redeboer
  2. 🔨 Maintenance
    redeboer
  3. 🔨 Maintenance
    redeboer
  4. 🔨 Maintenance
    redeboer
  5. 🔨 Maintenance
    redeboer
  6. 🔨 Maintenance
    redeboer
  7. Bug 🔨 Maintenance
    redeboer
  8. 🔨 Maintenance
    redeboer
  9. 🔨 Maintenance
    redeboer
  10. 🔨 Maintenance
    redeboer
  11. 🔨 Maintenance
    redeboer
  12. 🔨 Maintenance
    redeboer
@redeboer redeboer added the 🖱️ DX Improvements to the Developer Experience label May 30, 2023
@redeboer redeboer changed the title Investigate Ruff as linter Replace flake8, isort, and pylint with Ruff Jun 26, 2023
@redeboer redeboer changed the title Replace flake8, isort, and pylint with Ruff Replace flake8, isort, pydocstyle, and pylint with Ruff Jun 26, 2023
@redeboer redeboer changed the title Replace flake8, isort, pydocstyle, and pylint with Ruff Replace flake8, isort, pydocstyle, pylint, and pyupgrade with Ruff Jun 26, 2023
@redeboer redeboer self-assigned this Jun 27, 2023
@redeboer redeboer changed the title Replace flake8, isort, pydocstyle, pylint, and pyupgrade with Ruff Replace flake8, isort, pydocstyle, and pylint with Ruff Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment