Can you read this function! Can you make it more readable?

[pokhiii]

<?php

// namespace and imports.

class EffortTrackingService
{
    // Other service methods.

    public function getEffortForProject($project)
    {
        $users = User::with('projectTeamMembers');
        $sheetColumnsName = config('efforttracking.columns_name');
        try {
            $effortSheetUrl = $project->effort_sheet_url ?: $project->client->effort_sheet_url;

            if (! $effortSheetUrl) {
                return false;
            }

            $correctedEffortsheetUrl = [];

            $isSyntaxMatching = preg_match('/.*[^-\w]([-\w]{25,})[^-\w]?.*/', $effortSheetUrl, $correctedEffortsheetUrl);

            if (! $isSyntaxMatching) {
                return false;
            }

            $sheetId = $correctedEffortsheetUrl[1];
            $sheets = new Sheets();
            $projectMembersCount = 0;
            $lastColumn = config('efforttracking.default_last_column_in_effort_sheet');
            $columnIndex = 5;
            $projectsInSheet = [];

            $range = config('efforttracking.default_start_column_in_effort_sheet') . '2:' . config('efforttracking.default_start_column_in_effort_sheet');
            $sheet = $sheets->spreadsheet($sheetId)
                ->range($range)
                ->get();

            foreach ($sheet as $rows) {
                if (count($rows) == 0) {
                    break;
                }
                $projectMembersCount++;
            }

            try {
                while (true) {
                    $range = 'C1:' . ++$lastColumn . '1';
                    $sheet = $sheets->spreadsheet($sheetId)
                        ->range($range)
                        ->get();

                    if (isset($sheet[0]) && count($sheet[0]) == ++$columnIndex) {
                        $subProjectName = $sheet[0][count($sheet[0]) - 1];
                        $subProject = Project::where(['name' => $subProjectName, 'status' => 'active'])->first();
                        if ($subProject) {
                            $projectsInSheet[] = [
                                'id' => $subProject->id,
                                'name' => $subProjectName,
                                'sheetIndex' => $columnIndex - 1,
                            ];
                        }
                        continue;
                    }

                    $lastColumn = chr(ord((string) $lastColumn) - 1);
                    $columnIndex--;
                    break;
                }
            } catch (Exception $e) {
                return false;
            }

            $range = config('efforttracking.default_start_column_in_effort_sheet') . '2:' . $lastColumn . ($projectMembersCount + 1); // this will depend on the number of people on the project
            $sheetIndexForTeamMemberName = $this->getColumnIndex($sheetColumnsName['team_member_name'], $sheet[0]);
            $sheetIndexForTotalBillableEffort = $this->getColumnIndex($sheetColumnsName['billable_effort'], $sheet[0]);
            $sheetIndexForStartDate = $this->getColumnIndex($sheetColumnsName['start_date'], $sheet[0]);
            $sheetIndexForEndDate = $this->getColumnIndex($sheetColumnsName['end_date'], $sheet[0]);

            if ($sheetIndexForTeamMemberName === false || $sheetIndexForTotalBillableEffort === false || $sheetIndexForStartDate === false || $sheetIndexForEndDate === false) {
                return false;
            }

            if (count($projectsInSheet) == 0) {
                $projectsInSheet[] = [
                    'id' => $project->id,
                    'name' => $project->name,
                    'sheetIndex' => $sheetIndexForTotalBillableEffort,
                ];
            }

            try {
                $usersData = $sheets->spreadsheet($sheetId)
                    ->range($range)
                    ->get();
            } catch (Exception $e) {
                return false;
            }

            foreach ($usersData as $sheetUser) {
                try {
                    $userNickname = $sheetUser[$sheetIndexForTeamMemberName];
                    $portalUsers = clone $users;
                    $portalUser = $portalUsers->where('nickname', $userNickname)->first();

                    if (! $portalUser) {
                        continue;
                    }

                    $billingStartDate = Carbon::create($sheetUser[$sheetIndexForStartDate]);
                    $billingEndDate = Carbon::create($sheetUser[$sheetIndexForEndDate]);
                    $currentDate = now(config('constants.timezone.indian'))->today();

                    if ($currentDate < $billingStartDate || $currentDate > $billingEndDate) {
                        continue;
                    }

                    $effortData = [
                        'portal_user' => $portalUser,
                        'sheet_user' => $sheetUser,
                        'project' => $project,
                        'billing_start_date' => $billingStartDate,
                        'billing_end_date' => $billingEndDate,
                        'sheet_index_for_billable_effort' => $sheetIndexForTotalBillableEffort,
                    ];

                    foreach ($projectsInSheet as $sheetProject) {
                        try {
                            $effortData['sheet_project'] = $sheetProject;
                            $this->updateEffort($effortData);
                            ProjectMeta::updateOrCreate(
                                [
                                    'key' => config('project.meta_keys.last_updated_at.key'),
                                    'project_id' => $project->id,
                                ],
                                [
                                    'value' => now(config('constants.timezone.indian')),
                                ]
                            );
                        } catch (Exception $e) {
                            continue;
                        }
                    }
                } catch (Exception $e) {
                    continue;
                }
            }
        } catch (Exception $e) {
            return false;
        }

        return true;
    }
}

[GauravGusain98]

@pokhiii I think we can divide these functions into multiple small functions that way it can become more readable. I guess this function is violating many other principles like the Single responsibility principle, and the 3 indentation rule.

[GauravGusain98]

Can anyone suggest a function that we can separate from this logic?

[GauravGusain98]

One of such function that is coming to my mind is isEffortSheetUrlValid()

    $isSyntaxMatching = preg_match('/.*[^-\w]([-\w]{25,})[^-\w]?.*/', $effortSheetUrl, $correctedEffortsheetUrl);

    if (! $isSyntaxMatching) {
        return false;
    }

[rathorevaibhav]

I agree. In addition to this, here are my thoughts:

1. Maybe we should remove redundant code. For example, I don't think cloning the variable is needed here, because I don't see $portalUsers is being used anywhere else.

   $portalUsers = clone $users;
   $portalUser = $portalUsers->where('nickname', $userNickname)->first();

2. Complex piece of code like below should be moved to a separate function and should have a one-liner explanation of what is being done.

   $lastColumn = chr(ord((string) $lastColumn) - 1);