Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gif-land #32

Open
ScottRoberson opened this issue Dec 5, 2019 · 6 comments
Open

Gif-land #32

ScottRoberson opened this issue Dec 5, 2019 · 6 comments
Labels
👩‍💻 Project Started 🔄Updates / Changes Requested

Comments

@ScottRoberson
Copy link

Project Started
@w3cj
Copy link
Member

w3cj commented Dec 12, 2019

Asked by Scott:

I am nearing the end of the project and I am having a little trouble with the API data loading on the page before my loading image clears. Is there a way to delay the fetched data to display while the image stays on the screen? I have tried a timeout on the hide but the data loads in behind it. Here is a link to my code if it is needed for reference.

https://github.com/ScottRoberson/Gif-land

@w3cj
Copy link
Member

w3cj commented Dec 12, 2019

Please use the issue template and include your project details in this issue. See any other open issue for an example.

@ScottRoberson
Copy link
Author

Hi CJ! Where is the issue template located?

@w3cj
Copy link
Member

w3cj commented Dec 16, 2019

Issue template is here: https://raw.githubusercontent.com/CodingGarden/seedling-school-01-frontend-project/master/.github/ISSUE_TEMPLATE/project-submission.md

@ScottRoberson ScottRoberson changed the title https://github.com/ScottRoberson/Gif-land Gif-land Dec 17, 2019
@ScottRoberson
Copy link
Author

Site finished and deployed
https://youthful-easley-fe79a8.netlify.com

@w3cj
Copy link
Member

w3cj commented Dec 18, 2019

Nice! Would you like a ui review or code review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
👩‍💻 Project Started 🔄Updates / Changes Requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@w3cj @ScottRoberson