Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C-137 Browser #26

Open
1 of 6 tasks
miklosfeczko opened this issue Nov 23, 2019 · 8 comments
Open
1 of 6 tasks

C-137 Browser #26

miklosfeczko opened this issue Nov 23, 2019 · 8 comments

Comments

@miklosfeczko
Copy link

Project Name / Title

C-137 Browser

Your Name / Title

Miklos Feczko

Project Description

Get the character or characters based on search terms from Rick and Morty. Pagination between pages and a short information about each character will be listed.

What 3rd Party Web API do you plan to use?

Which of the following describes you:

  • YouTube Subscriber
  • Twitch Follower
  • Patreon Patron
  • Superchat Donor
  • Streamlabs Donor
  • Coding Garden Moderator
@miklosfeczko
Copy link
Author

  • Submitted / Description under review

@w3cj
Copy link
Member

w3cj commented Nov 23, 2019

Looks good to me! That API is so cool! Feel free to get started.

@miklosfeczko
Copy link
Author

The project is deployed and ready.

@mahendrjy
Copy link

Live

I love everything about your project

  • Landing page looks too amazing
  • I loved the left and right rotated navbar (it's looks amazing).
    Did you use transform: rotate(90deg) ?
  • Loading looks amazing when I search or go to next page
  • You are using pagination, too amazing.
    I always messed up pagination, it's seems too difficult to do. So I don't do it haha.

I know CSS is personal preference but please fix them haha

  • Home and Go to app are just too close, seem like it's a single nav and same with Github and About.
  • Increase the margins between them or
  • Put all of them in the corners, you can use something like this
.nav-link {
position: absolute;
top: 20px; /* or 40px or what you like or bottom */
left: 20px; /* or 40px or what you like or right */
}

@miklosfeczko
Copy link
Author

I used writing-mode: vertical-lr and text-orientation: sideways to rotate the text. I added margins between the nav elements. Thanks for the feedback.

@mahendrjy
Copy link

Ohh you used writing-mode. Amazing. I think text-orientation: sideways is default because I'm trying to play with it but nothing happens, I only see a difference when I set it to upright. Your welcome.

@w3cj
Copy link
Member

w3cj commented Dec 2, 2019

Would you like a ui review / code review?

@miklosfeczko
Copy link
Author

I would really appreciate a UI review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants