Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secret Pokemon Project Submission #25

Open
2 of 6 tasks
shinykoffin opened this issue Nov 23, 2019 · 11 comments
Open
2 of 6 tasks

Secret Pokemon Project Submission #25

shinykoffin opened this issue Nov 23, 2019 · 11 comments

Comments

@shinykoffin
Copy link

shinykoffin commented Nov 23, 2019

Project Name / Title

Give your project a good descriptive name

Your Name / Title

Alfredo / shinykoffin

Project Description

This app will let you know wich of the 800+ existing pokemon is your secret pokemon based on your birthdate and name.

What 3rd Party Web API do you plan to use?

@w3cj
Copy link
Member

w3cj commented Nov 23, 2019

Looks good to me! One question though, what will you do exactly to determine their secret pokemon?

Feel free to get started!

@shinykoffin
Copy link
Author

I had this image saved in my bookmarks for some reason. It describes a process of how to do it... https://imgur.com/gallery/mKd3DSM
Maybe I'll modify it a little because it was made when there was only 721 pokemon and now there's over 800

@shinykoffin
Copy link
Author

I have the wireframes. I had to re-do them because my API didn't have an element to describe the pokemon

@shinykoffin
Copy link
Author

Aaaand also the desktop version... I'm not very convinced with these ones, but I'm open to feedback


@mahendrjy
Copy link

I love the wireframes. I'm super excited to find out my secret pokemon.

@w3cj
Copy link
Member

w3cj commented Dec 2, 2019

Any updates to share?

@shinykoffin
Copy link
Author

Hello, sorry for not posting updates. I had a problem with my Mac so I did a reset... but I finished all the basic CSS styles, I almost died styling the select elements, this screenshots are from Firefox, in Chrome those ugly buttons do not show.

Now I'm ready to start with all the js stuff.
Hopefully I'll finish this saturday 😃
Some screenshots:



If you have feedback please comment, about colors, fonts, grammar, everything.

@shinykoffin
Copy link
Author

Sorry for the delay. I got the pokemon id calculation and API working! I just need to tweak a lot of details like reseting the app, and what happens if someone gets and ID > 807 and things like checking if the name inputs are empty and all that.

Here is a screenshot with my secret pokemon :D

@w3cj
Copy link
Member

w3cj commented Dec 14, 2019

Any updates to share? Let me know if you would like a ui / code review.

@shinykoffin
Copy link
Author

The update is that I’m stuck trying to implement animations and some loading bar.

But yeah I would like a code review. I mean not finished, I still have to adapt the site to desktop version and the animation things. But if you can give me feedback at this point I would appreciate that a lot 😊

@shinykoffin
Copy link
Author

Hello, I have an update!
I managed to put some simple animations and a simple loading spinning thing!
Now I just need to put some about page aaaand adapt the thing for bigger screens 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants