Skip to content
This repository has been archived by the owner on May 20, 2023. It is now read-only.

Loading animation in MediaDisplay fails after fading in or out #8

Open
CodedOre opened this issue Nov 12, 2021 · 4 comments
Open

Loading animation in MediaDisplay fails after fading in or out #8

CodedOre opened this issue Nov 12, 2021 · 4 comments
Labels
Milestone

Comments

@CodedOre
Copy link
Owner

Additionally to a progress bar MediaDisplay also uses the loading animation created for MediaPreview:

loading-display

To allow the animation to be hidden or shown (as the animation is part of MediaDisplay, not MediaDisplayItem), I've added additional css animations to fade an element in or out.
But having two animations on the same element seems not to be possible in GTK (the loading animation simply is still), so we need to look how we do this instead.

@CodedOre CodedOre added the ToDo label Nov 12, 2021
@CodedOre
Copy link
Owner Author

Since Adw.Animation was merged into main today, this might be something to consider.

Question then is though if we need or want a separate widget implementing the loading animation.

@IBBoard
Copy link
Contributor

IBBoard commented Nov 22, 2021

I know we've not got a deadline yet, and it's great that libadwaita is progressing… but how much will it restrict our supported distros? What's the lag like between commits to main and releases, and then releases to distros?

@CodedOre
Copy link
Owner Author

CodedOre commented Nov 22, 2021

I am using libadwaita (since I'm targeting GTK4), which is currently still in alpha. If I am right the first stable release will be together with Gnome 42 (next march).

So, native support will likely be from Fedora 36, Ubuntu 22.04 and similar.

I know you not really liking this, but basing it on GTK4 and libadwaita makes sense because of the new features (native dark style preference, Gtk.Picture and Gtk.MediaFile for easy media support) and will also make it more future-proof.

@IBBoard
Copy link
Contributor

IBBoard commented Nov 22, 2021

We've got to make a transition at some point. And a big break and redesign for the move to GTK4 makes more sense than partial coverage of features and distros by using an older (but still not widespread) libhandy. I'm just thinking of user numbers and how many people we lock out (who'll potentially complain).

I'm on openSUSE Tumbleweed, which is a rolling distro, and so I'm fine for up-to-date libraries 😁

@CodedOre CodedOre added this to the 2.0 milestone Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants