Glasgow | 26-Jul-SDC | Shreef Ibrahim | Sprint 5 | Prep Exercises - #662
Open
shreefAhmedM wants to merge 13 commits into
Open
Glasgow | 26-Jul-SDC | Shreef Ibrahim | Sprint 5 | Prep Exercises#662shreefAhmedM wants to merge 13 commits into
shreefAhmedM wants to merge 13 commits into
Conversation
…om str to List[str]
This comment has been minimized.
This comment has been minimized.
4 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
shreefAhmedM
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
shreefAhmedM
added
the
Needs Review
LonMcGregor
reviewed
Aug 12, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
Contributor
There was a problem hiding this comment.
Good start, but there is still some work to do here
One of the tasks, generics and printing out a family tree might be missing
| total_string = format_pence_as_string(total_pence) | ||
|
|
||
| print(f"The bank accounts total {total_string}") | ||
| def is_adult(person: Person) -> bool: |
Contributor
There was a problem hiding this comment.
Are these last few lines in the right file?
Contributor
There was a problem hiding this comment.
I think one of the tasks, explaining the difference between functions and methods is missing
| ] | ||
|
|
||
| for person in people: | ||
| possible_laptops = find_possible_laptops(laptops, person) |
Contributor
There was a problem hiding this comment.
When I run this, I get empty output. Do you see that? Why do you think this happens?
Author
There was a problem hiding this comment.
Yes, I see the error. i have updated.
Contributor
There was a problem hiding this comment.
This implementation works, but could the UX and input validation be improved?
LonMcGregor
added
Reviewed
shreefAhmedM
added
the
Needs Review
Contributor
|
Thanks for completing the missing tasks and updating this. This task is complete now |
LonMcGregor
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Sprint 5 prep exercises covering dataclasses, type annotations, enums, inheritance, methods, and refactoring and testing the code with mypy.
Task code: CYF-1155