Skip to content

Commit ba8d606

Browse files
author
Payman IB
committed
Refactor toPounds function for improved readability and consistency
1 parent 25347a2 commit ba8d606

File tree

1 file changed

+15
-10
lines changed

1 file changed

+15
-10
lines changed

Sprint-2/3-mandatory-implement/3-to-pounds.js

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,19 +5,24 @@
55

66
// You should call this function a number of times to check it works for different inputs
77

8+
function toPounds(penceString) {
9+
const penceStringWithoutTrailingP = penceString.substring(
10+
0,
11+
penceString.length - 1
12+
);
13+
const paddedPenceNumberString = penceStringWithoutTrailingP.padStart(3, "0");
14+
const pounds = paddedPenceNumberString.substring(
15+
0,
16+
paddedPenceNumberString.length - 2
17+
);
18+
const pence = paddedPenceNumberString
19+
.substring(paddedPenceNumberString.length - 2)
20+
.padEnd(2, "0");
821

9-
function toPounds(penceString){
10-
11-
const penceStringWithoutTrailingP = penceString.substring(0 , penceString.length - 1);
12-
const paddedPenceNumberString = penceStringWithoutTrailingP.padStart(3, "0");
13-
const pounds = paddedPenceNumberString.substring(0,paddedPenceNumberString.length - 2);
14-
const pence = paddedPenceNumberString.substring(paddedPenceNumberString.length - 2).padEnd(2, "0");
15-
16-
return ${pounds}.${pence}`;
17-
22+
return ${pounds}.${pence}`;
1823
}
1924
console.log(toPounds("399p"));
2025
console.log(toPounds("50p"));
2126
console.log(toPounds("5p"));
2227
console.log(toPounds("0p"));
23-
console.log(toPounds("12345p"));
28+
console.log(toPounds("12345p"));

0 commit comments

Comments
 (0)