Birmingham | 25-ITP-May | Tobias Amaechina|Sprint 1|Form control#1324
Open
Tobias-Amaechina wants to merge 12 commits into
Open
Birmingham | 25-ITP-May | Tobias Amaechina|Sprint 1|Form control#1324Tobias-Amaechina wants to merge 12 commits into
Tobias-Amaechina wants to merge 12 commits into
Conversation
…ing arial-describedby to aria-describedby in the fistname, last name and email, password input element
…me, email and password
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
Contributor
|
@Tobias-Amaechina please read through the issues the GitHub bot has raised and correct your PR template. You need to add a Label (right hand side of this page) titled "Needs Review" to submit this work for review. You will only be able to do that when the github bot doesn't find issues with the PR template |
Tobias-Amaechina
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
Author
|
I have added the needs review label |
This comment has been minimized.
This comment has been minimized.
Tobias-Amaechina
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
Tobias-Amaechina
added
the
Needs Review
Luro91
added
the
Review in progress
Luro91
reviewed
May 23, 2026
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
Please have a look at the lighthouse check. How could you get to a 100?
Comment on lines
+9
to
+10
| <style> | ||
| body { |
There was a problem hiding this comment.
How could you seperate the code for the styling from the html to make it easier to review (because of smaller files with seperate responsibilites)
Comment on lines
+86
to
+87
| <input type="email" id="email" name="email" required pattern="[a-z0-9._%+-]+@[a-z0-9.-]+\.[a-z]{2,}$" | ||
| aria-describedby="emailHelp"> |
There was a problem hiding this comment.
I find the code hard to read because of the formatting (long lines). How can you ensure consistent formatting in your code?
| </fieldset> | ||
| <!-- Last name--> | ||
| <fieldset> | ||
| <label for = "last-name">Last Name</label> |
There was a problem hiding this comment.
Why are there spaces bet ween the html attirbute and its value?
| <!-- First name--> | ||
| <fieldset> | ||
| <label for = "first-name">First Name</label> | ||
| <input type="text" id="first-name" name="first-name" required pattern=".*\S.*\S.*" |
There was a problem hiding this comment.
Good job on the validation. This works well
Luro91
removed
the
Needs Review
Luro91
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I have completed the Form Control assignment. The form collects customer information with the following fields:
2.Customer Email: Email input with validation for proper email format
4.T-Shirt Size: Dropdown menu with 6 options (XS, S, M, L, XL, XXL)
All form inputs are properly validated and the form meets the assignment requirements.
I agree to follow the code of conduct for this organisation