Skip to content

London | 226-SDC-Mar | Beko | Sprint 2 | Chat App both frontend and backend#85

Open
Abubakar-Meigag wants to merge 12 commits into
CodeYourFuture:mainfrom
Abubakar-Meigag:main
Open

London | 226-SDC-Mar | Beko | Sprint 2 | Chat App both frontend and backend#85
Abubakar-Meigag wants to merge 12 commits into
CodeYourFuture:mainfrom
Abubakar-Meigag:main

Conversation

@Abubakar-Meigag
Copy link
Copy Markdown

@Abubakar-Meigag Abubakar-Meigag commented May 26, 2026

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Built a real-time chat app with Vite + React + TypeScript frontend and Node.js + Express backend
  • REST API with GET /messages to load chat history and POST /messages to send messages
  • WebSocket broadcasts new messages instantly to all connected clients without page refresh
  • Added message count as an additional feature, with name persisted in localStorage across sessions

backend deployment link
https://ggjpdb4d0e0lrtcdbxpdpsrk.hosting.codeyourfuture.io

frontend deployment link
https://beeko-chat-apps.hosting.codeyourfuture.io/

@Abubakar-Meigag Abubakar-Meigag added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Decomposition The name of the module. labels May 26, 2026
@Abubakar-Meigag
Update README.md
262eec3
@Abubakar-Meigag
Create README.md for client with project details
1837065 
Added README.md for client-side documentation.
@Abubakar-Meigag
Create README.md for server documentation
898444b 
Added README.md for server documentation including technologies, structure, implementation details, and lessons learned.
cjyuan
cjyuan reviewed May 29, 2026
View reviewed changes
Copy link
Copy Markdown

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is well modularised.

Impressive use of React and WS. Could also explore Server Side Event (sse).

I only have a few comment and one question.

Comment thread chat-app/server/endPoints/postMessage.js
Comment thread chat-app/server/endPoints/postMessage.js Outdated
Comment on lines +15 to +18
timestamp: new Date().toLocaleTimeString([], {
hour: "2-digit",
minute: "2-digit",
}),
Copy link
Copy Markdown

@cjyuan cjyuan May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you suggest a strategy to ensure that users in different time zones see timestamps in their respective local time zones?

Copy link
Copy Markdown
Author

@Abubakar-Meigag Abubakar-Meigag May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now with this change, each user will see the time converted to their own timezone.

Copy link
Copy Markdown

@cjyuan cjyuan May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new Date().toISOString() is a time on UTC (not quite a "local time"). :) A better approach would be format the time on the client side.

Comment thread chat-app/server/endPoints/postMessage.js Outdated
Comment thread chat-app/client/src/App.tsx
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 29, 2026
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
cjyuan
cjyuan reviewed May 29, 2026
View reviewed changes
Comment thread README.md
Copy link
Copy Markdown

@cjyuan cjyuan May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the Validation Bot is not expecting this file to be modified. Can you do the following?

  • Move the content from this file to chat-app/README.md
  • Revert the changes made on this file

Copy link
Copy Markdown
Author

@Abubakar-Meigag Abubakar-Meigag May 29, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the feedback comments are done, including this one. I moved the content and did revert the changes

Thanks you @cjyuan

@Abubakar-Meigag Abubakar-Meigag added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels May 29, 2026
@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 29, 2026
@cjyuan
Copy link
Copy Markdown

cjyuan commented May 29, 2026

All good. Excellent work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Decomposition The name of the module. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Abubakar-Meigag @cjyuan