Skip to content

Commit 73d22a5

Browse files
authored
Merge pull request #176 from Rafalkufel/142-fix-team-member-edition
142 Validate team member data before save
2 parents 810a171 + 1498533 commit 73d22a5

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

alinka/schemas/db_schema.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
from datetime import date
22

3-
from pydantic import BaseModel, ConfigDict
3+
from pydantic import BaseModel, ConfigDict, Field
44

55

66
class BaseDbSchema(BaseModel):
@@ -96,8 +96,8 @@ class SupportCenterDbSchema(BaseDbSchema):
9696

9797

9898
class TeamMemberDbCreateSchema(BaseDbSchema):
99-
name: str
100-
function: str
99+
name: str = Field(..., min_length=1)
100+
function: str = Field(..., min_length=1)
101101

102102

103103
class TeamMemberDbSchema(TeamMemberDbCreateSchema):

alinka/widget/containers/main_body/content/settings/settings_tabs/team_member_tab/team_member_table_group.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,10 @@ def setData(self, index: QModelIndex, value: object, role: int = Qt.EditRole) ->
8181

8282
tm_dict = {k: self.data(index.siblingAtColumn(i)) for i, k in enumerate(self.columns)}
8383
tm_dict[self.columns[index.column()]] = value
84-
tm = TeamMemberDbSchema.model_validate(tm_dict)
84+
try:
85+
tm = TeamMemberDbSchema.model_validate(tm_dict)
86+
except ValidationError:
87+
return False
8588
upsert_team_members([tm])
8689

8790
self.dataChanged.emit(index, index)

0 commit comments

Comments
 (0)