Update notifications

Author: FastestMolasses

CodeEdit/Features/LSP/Registry/RegistryManager.swift

@@ -14,7 +14,7 @@ private let installPath = homeDirectory
     .appending(path: "Library")
     .appending(path: "Application Support")
     .appending(path: "CodeEdit")
-    .appending(path: "extensions")
+    .appending(path: "language-servers")
 
 final class RegistryManager {
     static let shared: RegistryManager = .init()
@@ -122,13 +122,34 @@ final class RegistryManager {
         guard let manager = Self.createPackageManager(for: method) else {
             throw PackageManagerError.invalidConfiguration
         }
-        try await manager.install(method: method)
 
+        // Add to activity viewer
+        let activityTitle = "\(entry.name)\("@" + (method.version ?? "latest"))"
+        NotificationCenter.default.post(
+            name: .taskNotification,
+            object: nil,
+            userInfo: [
+                "id": entry.name,
+                "action": "create",
+                "title": "Installing \(activityTitle)"
+            ]
+        )
+
+        do {
+            try await manager.install(method: method)
+        } catch {
+            Self.updateActivityViewer(entry.name, activityTitle, fail: true)
+            // Throw error again so the UI can catch it
+            throw error
+        }
+
+        // Save to settings
         installedLanguageServers[entry.name] = .init(
             packageName: entry.name,
             isEnabled: true,
             version: method.version ?? ""
         )
+        Self.updateActivityViewer(entry.name, activityTitle, fail: false)
     }
 
     /// Attempts downloading from `url`, with error handling and a retry policy
@@ -227,6 +248,55 @@ final class RegistryManager {
             return nil
         }
     }
+
+    /// Updates the activity viewer with the status of the language server installation
+    private static func updateActivityViewer(
+        _ id: String,
+        _ activityName: String,
+        fail failed: Bool
+    ) {
+        if failed {
+            NotificationCenter.default.post(
+                name: .taskNotification,
+                object: nil,
+                userInfo: [
+                    "id": id,
+                    "action": "update",
+                    "title": "Could not install \(activityName)",
+                    "isLoading": false
+                ]
+            )
+            NotificationCenter.default.post(
+                name: .taskNotification,
+                object: nil,
+                userInfo: [
+                    "id": id,
+                    "action": "deleteWithDelay",
+                    "delay": 5.0,
+                ]
+            )
+        } else {
+            NotificationCenter.default.post(
+                name: .taskNotification,
+                object: nil,
+                userInfo: [
+                    "id": id,
+                    "action": "update",
+                    "title": "Successfully installed \(activityName)",
+                    "isLoading": false
+                ]
+            )
+            NotificationCenter.default.post(
+                name: .taskNotification,
+                object: nil,
+                userInfo: [
+                    "id": id,
+                    "action": "deleteWithDelay",
+                    "delay": 5.0,
+                ]
+            )
+        }
+    }
 }
 
 /// `CachedRegistry` is a timer based cache that will remove the registry items from memory

CodeEdit/Features/Settings/Models/SettingsData.swift

@@ -109,7 +109,9 @@ struct SettingsData: Codable, Hashable {
         case .location:
             LocationsSettings().searchKeys.forEach { settings.append(.init(name, isSetting: true, settingName: $0)) }
         case .languageServers:
-            LanguageServerSettings().searchKeys.forEach { settings.append(.init(name, isSetting: true, settingName: $0)) }
+            LanguageServerSettings().searchKeys.forEach {
+                settings.append(.init(name, isSetting: true, settingName: $0))
+            }
         case .developer:
             developerSettings.searchKeys.forEach { settings.append(.init(name, isSetting: true, settingName: $0)) }
         case .behavior: return [.init(name, settingName: "Error")]

CodeEdit/Features/Settings/Pages/Extensions/LanguageServerRowView.swift

@@ -22,7 +22,6 @@ struct LanguageServerRowView: View, Equatable {
     @State private var isInstalling: Bool = false
     @State private var isInstalled: Bool = false
     @State private var isEnabled = false
-    @State private var installProgress: Double = 0.0
 
     init(
         packageName: String,
@@ -115,7 +114,7 @@ struct LanguageServerRowView: View, Equatable {
     @ViewBuilder
     private func isInstallingRow() -> some View {
         ZStack {
-            CECircularProgressView(progress: installProgress)
+            CECircularProgressView()
                 .frame(width: 20, height: 20)
             Button {
                 isInstalling = false
@@ -134,14 +133,9 @@ struct LanguageServerRowView: View, Equatable {
     private func isHoveringRow() -> some View {
         Button {
             isInstalling = true
-            withAnimation(.linear(duration: 3)) {
-                installProgress = 0.75
-            }
+
             Task {
                 await onInstall()
-                withAnimation(.linear(duration: 1)) {
-                    installProgress = 1.0
-                }
                 isInstalling = false
                 isInstalled = true
                 isEnabled = true

CodeEdit/Features/Settings/Pages/Extensions/LanguageServersView.swift

@@ -35,6 +35,7 @@ struct LanguageServersView: View {
                                 do {
                                     try await RegistryManager.shared.installPackage(package: item)
                                 } catch {
+                                    didError = true
                                     installationFailure = InstallationFailure(error: error.localizedDescription)
                                 }
                             }