Fix lint

Author: FastestMolasses

CodeEdit/Features/LSP/Registry/PackageManagers/GithubPackageManager.swift

@@ -40,11 +40,9 @@ class GithubPackageManager: PackageManagerProtocol {
         switch method {
         case let .binaryDownload(source, url):
             try await downloadBinary(source, url)
-            break
         case let .sourceBuild(source, command):
             try await installFromSource(source, command)
-            break
-        case .standardPackage(_), .unknown:
+        case .standardPackage, .unknown:
             throw PackageManagerError.invalidConfiguration
         }
     }
@@ -67,7 +65,7 @@ class GithubPackageManager: PackageManagerProtocol {
     }
 
     private func downloadBinary(_ source: PackageSource, _ url: URL) async throws {
-        let (data, _) = try await URLSession.shared.data(from: url)
+        _ = try await URLSession.shared.data(from: url)
         let fileName = url.lastPathComponent
         let downloadPath = installationDirectory.appending(path: source.name)
         let packagePath = downloadPath.appending(path: fileName)

CodeEdit/Features/LSP/Registry/PackageManagers/GolangPackageManager.swift

@@ -51,25 +51,7 @@ class GolangPackageManager: PackageManagerProtocol {
             let gobinPath = packagePath.appending(path: "bin", directoryHint: .isDirectory).path
             var goInstallCommand = ["env", "GOBIN=\(gobinPath)", "go", "install"]
 
-            if let gitRef = source.gitReference, let repoUrl = source.repositoryUrl {
-                // Check if this is a Git-based package
-                var packageName = source.name
-                if !packageName.contains("github.com") && !packageName.contains("golang.org") {
-                    packageName = repoUrl.replacingOccurrences(of: "https://", with: "")
-                }
-
-                var gitVersion: String
-                switch gitRef {
-                case .tag(let tag):
-                    gitVersion = tag
-                case .revision(let rev):
-                    gitVersion = rev
-                }
-
-                goInstallCommand.append("\(packageName)@\(gitVersion)")
-            } else {
-                goInstallCommand.append("\(source.name)@\(source.version)")
-            }
+            goInstallCommand.append(getGoInstallCommand(source))
             _ = try await executeInDirectory(in: packagePath.path, goInstallCommand)
 
             // If there's a subpath, build the binary
@@ -152,4 +134,26 @@ class GolangPackageManager: PackageManagerProtocol {
             line.contains(dependencyPath)
         }
     }
+
+    private func getGoInstallCommand(_ source: PackageSource) -> String {
+        if let gitRef = source.gitReference, let repoUrl = source.repositoryUrl {
+            // Check if this is a Git-based package
+            var packageName = source.name
+            if !packageName.contains("github.com") && !packageName.contains("golang.org") {
+                packageName = repoUrl.replacingOccurrences(of: "https://", with: "")
+            }
+
+            var gitVersion: String
+            switch gitRef {
+            case .tag(let tag):
+                gitVersion = tag
+            case .revision(let rev):
+                gitVersion = rev
+            }
+
+            return "\(packageName)@\(gitVersion)"
+        } else {
+            return "\(source.name)@\(source.version)"
+        }
+    }
 }