Player Kicked on Server Change #727

MacTh3Mac · 2023-09-22T19:18:12Z

Environment: Waterfall-1.20-537
Server: All Versions 1.12 through 1.20.1
Via-Version: 4.8.0
Via-Backwards: 4.8.0
Client Version: Only affects 1.20.2 Vanilla Minecraft Client

BungeeTabListPlus: Release and Build 114 from CI Server.

Upon attempting to change servers within a bungee network the following error is generated:

Internal Exception: io.nettyhandler.codec.DecoderException: z: Non [a-z0-9/._-] character in path of location: minecraft: BTLP4625264d 00

This error occurs with or without the Bukkit Bridge installed.

This error is resolved by removing BTLP from Bungee.

No log entries made on either server or bungee.

Edit: added error in plain text to enable copy/paste or web search / crawling etc.

The text was updated successfully, but these errors were encountered:

cobrex1 · 2023-09-23T04:55:15Z

I also get the same error, using waterfall-537 & 538 also. If the client is on 1.20.1, no issues, but on 1.20.2 the error above occurs.

gre3x · 2023-09-23T05:02:28Z

Seems to be a more wide spread thing related to Bungee. I'm unsure if this would need a fix on plugin side or Bungee side: SpigotMC/BungeeCord#3519

MacTh3Mac · 2023-09-23T10:33:47Z

Appears to be unresolved by:
SpigotMC/BungeeCord@0509303

MacTh3Mac · 2023-09-23T10:46:13Z

Update when running SpigotMC/BungeeCord@f9b75c4

Error Changes to:
EncoderException: java.lang.IllegalArgumentException: Cannot get ID for packet class net.md_5.bungee.protocol.packet.Team in phase CONFIGURATION with direction TO_CLIENT @ io.netty.handler.codec.MessageToByteEncoder:125

Error on Waterfall 538 remains as per previous comments when opening issue.
Internal Exception: io.nettyhandler.codec.DecoderException: z: Non [a-z0-9/._-] character in path of location: minecraft: BTLP4625264d 00

MacTh3Mac · 2023-09-23T11:26:53Z

Error Generated with BungeeCord:

https://pastebin.com/dUBUKpD8

NoltoxGit · 2023-09-23T13:23:42Z

I have the same problem.

HippieBeak · 2023-09-23T23:54:19Z

Looks like Bungee is suggesting that this might require a fix by BTLP rather than the Bungee side... SpigotMC/BungeeCord#3519 (comment)

gre3x · 2023-09-24T00:46:11Z

@CodeCrafter47 looks like md5 is saying that this requires a fix in BTLP SpigotMC/BungeeCord#3519 (comment)

PrinceBunBun981 · 2023-09-24T20:58:52Z

I remember this being mentioned on the Discord and thought to give a small update here, Code is aware of the issues with 1.20.2 and will be looking into it, I don't have an exact ETA though.

andrewkm · 2023-09-24T21:11:40Z

Same problem happening here @CodeCrafter47
https://i.imgur.com/kamuk6w.png

Andre601 · 2023-09-24T22:08:11Z

Tagging him won't make things faster or change them. He does see the issues and gets notified. Tagging him only wastes your time.

andrewkm · 2023-09-24T22:45:20Z

Tagging him won't make things faster or change them. He does see the issues and gets notified. Tagging him only wastes your time.

Typing out his name took me less than a second; my times not that valuable to consider a second wasted. Lol

crumpkatrina · 2023-09-24T22:49:55Z

We are also experiencing the same issue on our end.

Phoenix616 · 2023-09-26T12:25:24Z

This is most likely because BLTP is either a) sending packets with the wrong IDs or b) sending them during the login or new configuration phase which of course doesn't support those. (Haven't further looked into this though)

andfont · 2023-09-28T11:31:45Z

please! something new? He's throwing me out to the players, thanks!
although it is a temporary solution, greetings

dynamitestudios · 2023-09-28T20:09:11Z

Anybody have a workaround until this is fixed? (Except telling players to use 1.20.1, removing BTLP, or downgrading the server.)

HippieBeak · 2023-09-30T19:45:02Z

I’m probably going to have to switch over to TAB if this isn’t resolved soon… in the BTLP discord they made it seem like it’s not even a guarantee that this will be fixed… just that CodeCrafter “may” look into this

Andre601 · 2023-09-30T19:47:46Z

I’m probably going to have to switch over to TAB if this isn’t resolved soon… in the BTLP discord they made it seem like it’s not even a guarantee that this will be fixed… just that CodeCrafter “may” look into this

Curse of open source.
This project is maintained by one guy in his free time, which is not a lot and usually is used by by more important stuff.
You can't and shouldn't expect updates being made fast nor that it is maintained forever. This isn't a project managed by employees of a company paid for this stuff...

chrismwiggs · 2023-09-30T19:57:11Z

Curse of open source. This project is maintained by one guy in his free time, which is not a lot and usually is used by by more important stuff. You can't and shouldn't expect updates being made fast nor that it is maintained forever. This isn't a project managed by employees of a company paid for this stuff...

Came looking to see how likely it was that this issue would be looked at, to find this. If the project is abandoned, it would be nice to be marked as such. Not a demand or expectation of infinite support/service, just transparency is nice so when folks who depend on that work go to update, they know how to plan for the future.

Any chance of the dev or project lead commenting on this for clarity on even an intention to look at it? I get not having time to do it on demand but the communication is nice

andrewkm · 2023-09-30T20:02:03Z

I’m probably going to have to switch over to TAB if this isn’t resolved soon… in the BTLP discord they made it seem like it’s not even a guarantee that this will be fixed… just that CodeCrafter “may” look into this

We’ve decided to just fork it privately and fix it ourselves along side a few other things we’ve wanted implemented for quite some time. May as well do so as well on your end. No use waiting if you need it quick. I'm sure eventually it'll be done here too.

Andre601 · 2023-09-30T20:06:22Z

Came looking to see how likely it was that this issue would be looked at, to find this. If the project is abandoned, it would be nice to be marked as such. Not a demand or expectation of infinite support/service, just transparency is nice so when folks who depend on that work go to update, they know how to plan for the future.

Any chance of the dev or project lead commenting on this for clarity on even an intention to look at it? I get not having time to do it on demand but the communication is nice

It's not abandoned (And I in fact never said this in my message). It's just the simple fact that the main (And only) dev of the project does not have any time to spent on this project. This usually also includes not having time to write any comments. But I can assure you that CodeCrafter knows about this issues and wants to look into them. He just can't affort the time necessary for all of this.

It's something most people forget all the time when using plugins like BTLP. That a free resource may not have countless people behind it working on it.

We’ve decided to just fork it privately and fix it ourselves along side a few other things we’ve wanted implemented for quite some time. May as well do so as well on your end. No use waiting if you need it quick. I'm sure eventually it'll be done here too.

Well, they may not have the knowledge? Just because you forked and fixed the problem doesn't mean other people have the knowledge to do so either...
Also, it would probably be a better move to also propose these fixes as a PR, as it could help fixing the issue faster, since CodeCrafter wouldn't need to spend time finding and fixing it himself and could instead just review the changes, maybe give some corrections and merge it if it is good.

Kas-tle · 2023-10-01T08:55:45Z

Should be resolved with merge of #729 in latest update.

MacTh3Mac · 2023-10-01T10:04:55Z

Latest Update Resolves kick errors but introduces new issue.

Tab list formatting is lost on Server Change, Doesn't show tab list designated to server. (issue on Bungeecord / waterfall latest)

Tested against:
BungeeCord: SpigotMC/BungeeCord@1ef4d27
Waterfall: PaperMC/Waterfall@ce48007
BTLP Version: 3.6.2 (Spigot Release) & BTLP 3.6.1-SNAPSHOT (https://ci.codecrafter47.de/job/BungeeTabListPlus/1141/)

MacTh3Mac · 2023-10-01T10:06:06Z

Additional Info Ref: #727 (comment)

Correct Tab List is displayed when 1st Joining, Issue only occurs after Server Change.

MacTh3Mac · 2023-10-01T11:01:03Z

Additional info Ref: #727 (comment)

This display issue affects 1.20.2 Clients Only. Lower Versions unaffected.

andrewkm · 2023-10-01T22:51:08Z

Latest Update Resolves kick errors but introduces new issue.

Tab list formatting is lost on Server Change, Doesn't show tab list designated to server. (issue on Bungeecord / waterfall latest)

Tested against: BungeeCord: SpigotMC/BungeeCord@1ef4d27 Waterfall: PaperMC/Waterfall@ce48007 BTLP Version: 3.6.2 (Spigot Release) & BTLP 3.6.1-SNAPSHOT (https://ci.codecrafter47.de/job/BungeeTabListPlus/1141/)

Cannot reproduce.
Can you provide more information ,or an example.

Phoenix616 · 2023-10-02T09:28:59Z

While the kick seems fixed to me it wont display any players after server switch.

I only use one global tablist though, not a per-server one.

EDIT: To make it clear as an omission usually isn't: There is also no error in the log

HippieBeak · 2023-10-02T13:54:47Z

I can reproduce with the global tablist.

Login to a server with BTLP
Switch to another server using BTLP (at this point, the tablist should still be working)
Log out
You should see the below error in your Bungee console:

java.lang.NullPointerException: Cannot invoke "net.md_5.bungee.protocol.MinecraftEncoder.getProtocol()" because the return value of "io.netty.channel.ChannelPipeline.get(java.lang.Class)" is null
        at net.md_5.bungee.netty.ChannelWrapper.getEncodeProtocol(ChannelWrapper.java:51) ~[waterfall.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:4d5746a:544]
        at net.md_5.bungee.UserConnection.sendPacketQueued(UserConnection.java:194) ~[waterfall.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:4d5746a:544]
        at codecrafter47.bungeetablistplus.handler.NewTabOverlayHandler.sendPacket(NewTabOverlayHandler.java:187) ~[?:?]
        at codecrafter47.bungeetablistplus.handler.NewTabOverlayHandler.access$700(NewTabOverlayHandler.java:54) ~[?:?]
        at codecrafter47.bungeetablistplus.handler.NewTabOverlayHandler$CustomContentTabOverlayHandler.onDeactivated(NewTabOverlayHandler.java:701) ~[?:?]
        at codecrafter47.bungeetablistplus.handler.NewTabOverlayHandler$AbstractContentOperationModeHandler.invalidate(NewTabOverlayHandler.java:391) ~[?:?]
        at codecrafter47.bungeetablistplus.handler.NewTabOverlayHandler.update(NewTabOverlayHandler.java:354) ~[?:?]
        at io.netty.util.concurrent.AbstractEventExecutor.runTask(AbstractEventExecutor.java:173) ~[waterfall.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:4d5746a:544]
        at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:166) ~[waterfall.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:4d5746a:544]
        at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:470) ~[waterfall.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:4d5746a:544]
        at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:413) ~[waterfall.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:4d5746a:544]
        at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997) ~[waterfall.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:4d5746a:544]
        at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) ~[waterfall.jar:git:Waterfall-Bootstrap:1.20-R0.2-SNAPSHOT:4d5746a:544]
        at java.lang.Thread.run(Thread.java:833) [?:?]

Log back in, and repeat starting at step 1
When you switch servers, you will no longer appear in the tablist

MacTh3Mac · 2023-10-02T15:11:48Z

Steps to reproduce: Join Bungee Network. (Correct tab List is Shown). in all client versions
Change Server to a server that should display either a server specific tab list or global tab list.
Tab list shown has players in wrong order, gaps, formatting is incorrect places, Only on client version 1.20.2

No errors generated in logs, Doesn't occur on Client Versions 1.20.1 or lower.

Below are 2 example tab lists, the issue is the same for global tablists as well as the server specific tablist as shown in the example below that is shown on our long-term hubs.

Is some of the formatting not making it to the client?

If it helps, Environment All Linux, multiple bungees with player data synced with redis-bungee (all on waterfall). I have also tested on a single non-load balanced and data shared bungee and the issue persists.

Tablist Shown on 1st Join

Tablist Shown after Server Change

I also have logs spammed with this error upon disconnect only.
https://pastebin.com/7jypXQ4N

Note the error is on final user proxy disconnect, not server change / join or otherwise. Log produced on Test Proxy running Bungeecord (not waterfall)

CodeCrafter47 · 2023-10-02T16:01:42Z

Does this issue involve ViaVersion? If so, can the issue be fixed by installing ViaVersion on the backend servers only, that is not on the proxy?

Kas-tle · 2023-10-02T16:38:31Z

We can resolve the error sent by @HippieBeak and @MacTh3Mac by checking if the connection is valid before queuing packets, but it seems that this error is not related to odd issues that occur after switching servers. Based on HippieBeak's note that it only occurs after leaving and rejoining, I suspect some data is somehow persisting in the packet queue after we terminate the connection and this leads to issues when a player rejoins until after proxy restart.

MacTh3Mac · 2023-10-02T16:53:35Z

Does this issue involve ViaVersion? If so, can the issue be fixed by installing ViaVersion on the backend servers only, that is not on the proxy?

We have never used Via-Version on proxies, far too many bugs.

MacTh3Mac · 2023-10-02T16:59:36Z

but it seems that this error is not related to odd issues that occur after switching servers. Based on HippieBeak's note that it only occurs after leaving and rejoining, I suspect some data is somehow persisting in the packet queue after we terminate the connection and this leads to issues when a player rejoins until after proxy restart.

The tab list display issues can be recreated on a fresh proxy, busy proxy, empty proxy. on 1st join (proxy) and rejoin (proxy without restart). It appears to be inherent in all situations using a 1.20.2 client. And only on subsequent servers. Primary connection irrespective of which backend server the player arrives on always displays the correct tab list. It's only after a backend server charge that all future tablists remain mis-displayed, including if you return back to the original connected backend server.

Feel free to hop around our network on a 1.20.2 client and the issue should become immediately apparent. Details in Screenshot in prior replies.

HippieBeak · 2023-10-03T13:41:19Z

I cannot reproduce it on first join.

MacTh3Mac · 2023-10-04T20:04:25Z

Resolved By: a05bead

New Issues on incorrect display moved to new issue #731

andrewkm mentioned this issue Oct 3, 2023

Bungee errors on server disconnect. #730

Closed

MacTh3Mac mentioned this issue Oct 4, 2023

Incorrect Tab List Displayed on Server Change Using 1.20.2 Client #731

Closed

MacTh3Mac closed this as completed Oct 4, 2023

donvdp mentioned this issue Oct 11, 2023

Incorrect Tab List Displayed on Server Change Using 1.20.2 Client #732

Open

Player Kicked on Server Change #727

Player Kicked on Server Change #727

Comments

MacTh3Mac commented Sep 22, 2023 • edited Loading

cobrex1 commented Sep 23, 2023

gre3x commented Sep 23, 2023 • edited Loading

MacTh3Mac commented Sep 23, 2023

MacTh3Mac commented Sep 23, 2023

MacTh3Mac commented Sep 23, 2023

NoltoxGit commented Sep 23, 2023

HippieBeak commented Sep 23, 2023

gre3x commented Sep 24, 2023

PrinceBunBun981 commented Sep 24, 2023

andrewkm commented Sep 24, 2023

Andre601 commented Sep 24, 2023

andrewkm commented Sep 24, 2023

crumpkatrina commented Sep 24, 2023

Phoenix616 commented Sep 26, 2023

andfont commented Sep 28, 2023 • edited Loading

dynamitestudios commented Sep 28, 2023

HippieBeak commented Sep 30, 2023

Andre601 commented Sep 30, 2023

chrismwiggs commented Sep 30, 2023

andrewkm commented Sep 30, 2023 • edited Loading

Andre601 commented Sep 30, 2023

Kas-tle commented Oct 1, 2023

MacTh3Mac commented Oct 1, 2023

MacTh3Mac commented Oct 1, 2023

MacTh3Mac commented Oct 1, 2023

andrewkm commented Oct 1, 2023

Phoenix616 commented Oct 2, 2023 • edited Loading

HippieBeak commented Oct 2, 2023 • edited Loading

MacTh3Mac commented Oct 2, 2023

CodeCrafter47 commented Oct 2, 2023

Kas-tle commented Oct 2, 2023

MacTh3Mac commented Oct 2, 2023

MacTh3Mac commented Oct 2, 2023

HippieBeak commented Oct 3, 2023

MacTh3Mac commented Oct 4, 2023

MacTh3Mac commented Sep 22, 2023 •

edited

Loading

gre3x commented Sep 23, 2023 •

edited

Loading

andfont commented Sep 28, 2023 •

edited

Loading

andrewkm commented Sep 30, 2023 •

edited

Loading

Phoenix616 commented Oct 2, 2023 •

edited

Loading

HippieBeak commented Oct 2, 2023 •

edited

Loading