Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use environment instead of config #61

Open
sgkim126 opened this issue Jun 12, 2019 · 8 comments
Open

Use environment instead of config #61

sgkim126 opened this issue Jun 12, 2019 · 8 comments

Comments

@sgkim126
Copy link
Contributor

Currently, there are two ways to set up the configuration, because each tool is written by the various developers.
One is using config and the other is using environments.
Some developers, including me, prefer config to environments because the environments vanish when the session closes.
And others prefer environments because it corrupts the git history and it's still hard to track because it depends on environments to choose the configuration file.

But now, we can keep the environment because we use tmuxinator, so I think it's better to unify styles by using environment variables.

@sgkim126
Copy link
Contributor Author

@HoOngEe @majecty @foriequal0 What do you think about it?

@majecty
Copy link
Contributor

majecty commented Jun 12, 2019

I agree to unify them. Both config and ENV variable have some inconvenience, but I agree to unify it with the Environment variable.

@kseo kseo changed the title Use envrionment instead of config Use environment instead of config Jun 12, 2019
@foriequal0
Copy link
Contributor

foriequal0 commented Jun 12, 2019

Do you mean that using config is to use JSON file or a ts file like tick-tock, and using environment variables is like fee-monitor?
I was intended to use an environment variable to switch some targets (dev, corgi, mainnet) or some temporary fields. It was complementary to the config file.

@sgkim126
Copy link
Contributor Author

@foriequal0 Using the chain name is not flexible to run various testnet. Please change it to use the environment to set the variable it needed instead of hard-coding it.

@foriequal0
Copy link
Contributor

I don't think we need that much flexibility. Selecting between presets like codechain --chain solo would be enough to us.

@sgkim126
Copy link
Contributor Author

@foriequal0 FYI, --chain option can set the file, you can run any chain not only the pre-defined one.
And #60 it's the one example of the inflexibility of fee-monitor. We can add more testnet to test some features and you should modify code every time you add the testnet.

@foriequal0
Copy link
Contributor

foriequal0 commented Jun 12, 2019

Okay. Should we make them designate config file? I think we need to make the config overlappable like ~/.gitconfig to store sensitive and sharable data.

@sgkim126
Copy link
Contributor Author

@foriequal0 Why not using environment variables?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants