-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use environment instead of config #61
Comments
@HoOngEe @majecty @foriequal0 What do you think about it? |
I agree to unify them. Both |
Do you mean that using |
@foriequal0 Using the chain name is not flexible to run various testnet. Please change it to use the environment to set the variable it needed instead of hard-coding it. |
I don't think we need that much flexibility. Selecting between presets like |
@foriequal0 FYI, --chain option can set the file, you can run any chain not only the pre-defined one. |
Okay. Should we make them designate config file? I think we need to make the config overlappable like |
@foriequal0 Why not using environment variables? |
Currently, there are two ways to set up the configuration, because each tool is written by the various developers.
One is using
config
and the other is using environments.Some developers, including me, prefer
config
to environments because the environments vanish when the session closes.And others prefer environments because it corrupts the git history and it's still hard to track because it depends on environments to choose the configuration file.
But now, we can keep the environment because we use tmuxinator, so I think it's better to unify styles by using environment variables.
The text was updated successfully, but these errors were encountered: