Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send a slack notification immediately #43

Open
sgkim126 opened this issue Apr 30, 2019 · 3 comments
Open

Send a slack notification immediately #43

sgkim126 opened this issue Apr 30, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@sgkim126
Copy link
Contributor

Hi @HoOngEe,

this.sendDebounced = _.debounce(() => {
this.send();
}, 1500);

The current implementation waits 1.5 seconds before sending a notification.
Would you explain the reason?

@sgkim126 sgkim126 added the question Further information is requested label Apr 30, 2019
@HoOngEe
Copy link
Contributor

HoOngEe commented May 2, 2019

@majecty I remember I copied and pasted this code from your another slack notification code. Could you answer the question?

@majecty
Copy link
Contributor

majecty commented May 2, 2019

Slack API has a rate limit.
GoCryptobot server sent many logs when the server is down a few minutes.

If the monitor doesn't send too many requests in a minute, we don't need the code.

@sgkim126 sgkim126 changed the title [monitor] Why do monitor wait 1.5 seconds to send a notification Send a slack notification immediately May 3, 2019
@sgkim126
Copy link
Contributor Author

sgkim126 commented May 3, 2019

Thank you for an answer, @majecty.
I changed the title.

@sgkim126 sgkim126 added enhancement New feature or request and removed question Further information is requested labels May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants