Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timer cancellation is not reliable #1780

Open
foriequal0 opened this issue Sep 20, 2019 · 0 comments
Open

Timer cancellation is not reliable #1780

foriequal0 opened this issue Sep 20, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@foriequal0
Copy link
Contributor

We detect whether the timer was canceled in ad-hoc ways.
Especially, if a lock is involved, the situation is not desirable.
This commit addresses that: 96f7f94

We need a regular mechanism to know fired timeout is canceled, not by ad-hoc devised ways if we can't control it.
@kseo kseo added the bug Something isn't working label Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kseo @foriequal0