You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some caller function code is now using useless conversion from Action to ShardTransaction though the conversion was already implemented inside of the tracker() of Action.
As well as the above, after the pr#1548, the implementations will become inconsistent. Previously the tracker was needed only for asset transactions, but now the WrapCCC needs tracker though it's not an asset transaction.
From this semantic inconsistency, there is an implementation gap between tracker() of Action and the others. Therefore, the refactoring needs for tracker() and related caller functions not to be confused in the future.
The text was updated successfully, but these errors were encountered:
HoOngEe
changed the title
Tracker method calling part needs to be refactored.
Tracker method calling part needs to be refactored
Sep 5, 2019
Now the
tracker()
method can be called through the structsShardTransaction
,Action
andTransaction
.Some caller function code is now using useless conversion from
Action
toShardTransaction
though the conversion was already implemented inside of thetracker()
ofAction
.As well as the above, after the pr#1548, the implementations will become inconsistent. Previously the tracker was needed only for asset transactions, but now the
WrapCCC
needs tracker though it's not an asset transaction.From this semantic inconsistency, there is an implementation gap between
tracker()
ofAction
and the others. Therefore, the refactoring needs fortracker()
and related caller functions not to be confused in the future.The text was updated successfully, but these errors were encountered: