Some resource agents still use egrep/fgrep.

[SatomiOSAWA]

Hi all!

I noticed that egrep command is issuing warnings when trying to create a ping resource on RHEL 10.0 beta,
and I have submitted a PR to address it.
ClusterLabs/pacemaker#3775

It seems that there are some RAs and test tools in resource-agents which use egrep/fgrep as well.

[root@rh10-b03 resource-agents]# find . -name '*' -type f | xargs grep -e 'egrep' -e 'fgrep'
./configure.ac:AC_PATH_PROGS(EGREP, egrep)
./configure.ac:if export -p | fgrep " CFLAGS=" > /dev/null; then
./heartbeat/IPaddr2:    if egrep -q "(^|,)${IP_INC_NO}(,|$)" $IP_CIP_FILE ; then
./heartbeat/ManageVE.in:`echo "$OCF_RESKEY_veid" | egrep -q '^[[:digit:]]+$'`
./heartbeat/SAPInstance:      if [ `echo "$SERVICE" | egrep -c "$SEARCH"` -eq 1 ]
./heartbeat/VirtualDomain:              elif echo "$migrate_opts" | fgrep -qs -- "--migrateuri="; then
./heartbeat/VirtualDomain:      DOMAIN_NAME=`egrep '[[:space:]]*<name>.*</name>[[:space:]]*$' ${OCF_RESKEY_config} 2>/dev/null | sed -e 's/[[:space:]]*<name>\(.*\)<\/name>[[:space:]]*$/\1/'`
./heartbeat/WAS:  netstat -ltnp  2>/dev/null| egrep -i "($pat) .*LISTEN" | sed 's%.*LISTEN *%%'
./heartbeat/WAS6:  netstat -ltnp  2>/dev/null| egrep -i "($pat) .*LISTEN" | sed 's%.*LISTEN *%%'
./heartbeat/docker:     docker images | awk '{print $1 ":" $2}' | egrep -q -s "^(docker.io\/|${SERVER_NAME}\/)?${IMAGE_NAME}:${IMAGE_TAG}\$"
./heartbeat/eDir88.in:        RET=$($NDSTRACE --config-file "$NDSCONF" -c modules | egrep -i '^vrdim.*Running' | awk '{print $1}')
./heartbeat/mysql-proxy:    echo $log_level | egrep -q "^(error|warning|info|message|debug|)$"
./heartbeat/portblock:  echo $1 |egrep -qx '[0-9]+(:[0-9]+)?(,[0-9]+(:[0-9]+)?)*'
./heartbeat/rabbitmq-server-ha:        echo "${pid_param}" | egrep -q '^[0-9]+$'
./heartbeat/sapdb.sh:        if [ `echo "$SERVICE" | egrep -c "$SEARCH"` -eq 1 ]
./heartbeat/smb-share.in:            if [ $(testparm -s 2>/dev/null| egrep -c \\[$OCF_RESKEY_share\\]) -eq 1 ];then
./heartbeat/smb-share.in:            if [ $(testparm -s 2>/dev/null| egrep -c \\[$OCF_RESKEY_share\\]) -eq 1 ];then
./heartbeat/symlink:    elif readlink -m "$OCF_RESKEY_link" | egrep -q "^$(readlink -m ${OCF_RESKEY_target})$"; then
./heartbeat/eDir88:        RET=$($NDSTRACE --config-file "$NDSCONF" -c modules | egrep -i '^vrdim.*Running' | awk '{print $1}')
./heartbeat/smb-share:            if [ $(testparm -s 2>/dev/null| egrep -c \\[$OCF_RESKEY_share\\]) -eq 1 ];then
./heartbeat/smb-share:            if [ $(testparm -s 2>/dev/null| egrep -c \\[$OCF_RESKEY_share\\]) -eq 1 ];then
./heartbeat/ManageVE:`echo "$OCF_RESKEY_veid" | egrep -q '^[[:digit:]]+$'`
./tools/ocft/apache:    if systemctl list-unit-files 2>/dev/null | fgrep -q apache2.service; then
./tools/ocft/iscsi:     if systemctl list-unit-files 2>/dev/null | fgrep -q iscsid.service; then
./tools/ocft/iscsi:     if systemctl list-unit-files 2>/dev/null | fgrep -q target.service; then
./tools/ocft/iscsi:     if systemctl list-unit-files 2>/dev/null | fgrep -q target.service; then
./tools/ocft/mysql:     if systemctl list-unit-files 2>/dev/null | fgrep -q mysql.service; then
: (snip)

It’s easy to replace them automatically.
However, due to limitations in my environment,
I am unfortunately only able to test some of them, not all.
Therefore, I am submitting this issue simply to inform you of the matter.
I would be glad if this can be of any help.

Regards,
Satomi OSAWA

[oalbrigt]

I'll make a patch to fix it.

[SatomiOSAWA]

@oalbrigt
Thank you so much!