Dev: migration: allow to run migration locally (jsc#PED-8252) (#1836)

Author: zzhou1

crmsh/migration.py

@@ -156,9 +156,12 @@ def to_check_return_code(self) -> CheckReturnCode:
         return ret
 
 
-def migrate():
+def migrate(args: typing.Sequence[str]):
+    parser = argparse.ArgumentParser(args[0])
+    parser.add_argument('--local', action='store_true')
+    parsed_args = parser.parse_args(args[1:])
     try:
-        match _check_impl(local=False, json='', summary=False):
+        match _check_impl(local=parsed_args.local, json='', summary=False):
             case CheckReturnCode.ALREADY_MIGRATED:
                 logger.info("This cluster works on SLES 16. No migration is needed.")
                 return 0
@@ -167,7 +170,7 @@ def migrate():
                 return 0
             case CheckReturnCode.PASS_NEED_AUTO_FIX:
                 logger.info('Starting migration...')
-                migrate_corosync_conf()
+                migrate_corosync_conf(local=parsed_args.local)
                 logger.info('Finished migration.')
                 return 0
             case _:
@@ -372,7 +375,7 @@ def _check_unsupported_corosync_transport(handler: CheckResultHandler, dom):
     )
 
 
-def migrate_corosync_conf():
+def migrate_corosync_conf(local: bool):
     conf_path = corosync.conf()
     with open(conf_path, 'r', encoding='utf-8') as f:
         config = corosync_config_format.DomParser(f).dom()
@@ -387,16 +390,17 @@ def migrate_corosync_conf():
         'Finish migrating corosync configuration. The original configuration is renamed to %s.bak',
         os.path.basename(conf_path),
     )
-    for host, result in prun.pcopy_to_remote(
-            conf_path,
-            utils.list_cluster_nodes_except_me(), conf_path,
-            atomic_write=True,
-    ).items():
-        match result:
-            case None:
-                pass
-            case prun.PRunError() as e:
-                logger.error("Failed to copy crmsh.conf to host %s: %s", host, e)
+    if not local:
+        for host, result in prun.pcopy_to_remote(
+                conf_path,
+                utils.list_cluster_nodes_except_me(), conf_path,
+                atomic_write=True,
+        ).items():
+            match result:
+                case None:
+                    pass
+                case prun.PRunError() as e:
+                    logger.error("Failed to copy crmsh.conf to host %s: %s", host, e)
 
 
 def migrate_corosync_conf_impl(config):

crmsh/ui_cluster.py

@@ -839,7 +839,7 @@ def do_health(self, context, *args):
             case 'sles16':
                 try:
                     if parsed_args.fix:
-                        migration.migrate()
+                        migration.migrate(['sles16'] + remaining_args)
                     else:
                         return 0 == migration.check(['sles16'] + remaining_args)
                 except migration.MigrationFailure as e:

doc/crm.8.adoc

@@ -1010,20 +1010,16 @@ Usage 2: Topic-Specified Health Check
 Verifies the health of a specified topic.
 
 ...............
-health hawk2|sles16 [--fix]
+health hawk2|sles16 [--local] [--fix]
 ...............
 
 * `hawk2`: check or fix key-based ssh authentication for user hacluster, which
-is needed by hawk2.
+  is needed by hawk2.
+    ** `--fix`: attempts to automatically resolve any detected issues, eg.
+       hacluster passwordless
 * `sles16`: check whether the cluster is good to migrate to SLES 16.
-
-The optional `--fix` argument attempts to automatically resolve any detected
-issues.
-
-.Note on sles16
-****************************
-`--fix` is only available after the OS is migrated to SLES 16.
-****************************
+    ** `--local`: run checks in local mode
+    ** `--fix`: attempts to automatically resolve any detected issues.
 
 [[cmdhelp.cluster.init,Initializes a new HA cluster,From Code]]
 ==== `init`