Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check and fix how to work with the project from both, Visual Studio and VS Code #5

Open
MohamedRadwan-DevOps opened this issue May 10, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@MohamedRadwan-DevOps
Copy link
Member

Make sure that we can open the project in both tools and fix what is needed

@MohamedRadwan-DevOps MohamedRadwan-DevOps added the enhancement New feature or request label May 10, 2020
@mohammed-taha11
Copy link
Contributor

Hello Mohamed,
the project already opened and work at the both tools (VS & VS code). I just allowed some extension on VS code such as chrome debugger and add launch request for browser type at configuration.
is this the requirements ?

@MohamedRadwan-DevOps
Copy link
Member Author

Thanks, @mohammed-taha11 Yes, I didn't open the project from VS Code before and I wanted to make sure it's working fine and also clean any none source control file, also there another ticket which merged the UI automation with the app and the javascript and also to make sure that this working from VS Code as well.

For your change, I saw you have closed your pull request. So, I am not sure if you don't want to merge your changes. Also, looking at your changes, I would prefer to create a PR which has small changes instead of doing many changes in one PR

@mohammed-taha11
Copy link
Contributor

Thanks Mohamed for your great effort, really appreciated. the pull request has been created. and I will create PR for each small change from the next time ins Allah.

@MohamedRadwan-DevOps
Copy link
Member Author

Great @mohammed-taha11 I have accepted your PR, thank you so much for the great effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants