Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update in ClinVar json submission schema probably responsible for failing submissions #4868

Closed
northwestwitch opened this issue Sep 18, 2024 · 4 comments
Assignees

Comments

@northwestwitch
Copy link
Member

northwestwitch commented Sep 18, 2024

If you provide any text in that field then you submission fails. This is because The select above contained 2 fields that now are gone: "drug response" and "other". You were supposed to fill in "Comment on clinical significance" only if one of these 2 fields were provided.

image

@northwestwitch
Copy link
Member Author

@ehre

@ehre
Copy link

ehre commented Sep 18, 2024

I'm unsure. Please see email with details, @northwestwitch

@northwestwitch northwestwitch changed the title Remove "Comment on clinical significance" from the Clinvar form Update in ClinVar json submission schema probably responsible for failing submissions Sep 19, 2024
@northwestwitch
Copy link
Member Author

I've tested again the submission from yesterday and it went through:

image

I've also noticed that their pages that yesterday were offline are working today:

image

So perhaps it's not our fault after all?

I'm m the update of the json submission schema, see the PR in preclinVar but I've noticed that the new schema is not breaking our test, which means our way of submitting should still be supported!

@northwestwitch
Copy link
Member Author

Closing this issue as submitting worked also for Lund!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants