Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silently missing values when using integer format in rank model and encountering a float value #128

Open
Jakob37 opened this issue Mar 19, 2024 · 2 comments

Comments

@Jakob37
Copy link
Contributor

Jakob37 commented Mar 19, 2024

We had an issue where some GATK only structural variants did not obtain a rank score.

Looking closer, we found that we had mistakenly specified "integer" as format on GATKs quality GQC field and specified integer ranges.

Some of the GATK GQC values were actually floats. These silently got no rank scores.

It would be useful to get complaints from Genmod when encountering values of formats outside those written in the rank model.

I wanted to share the info as it might save someone else some headache.

@henrikstranneheim
Copy link
Collaborator

Thanks for the feedback. Our main developer is currently on parental leave until the fall. So this'll probably be on hold until then. We are also focusing our efforts creating a new app which will replace genmod and use more sophisticated prioritization models.

@Jakob37
Copy link
Contributor Author

Jakob37 commented Mar 19, 2024

Thanks for the feedback. Our main developer is currently on parental leave until the fall. So this'll probably be on hold until then. We are also focusing our efforts creating a new app which will replace genmod and use more sophisticated prioritization models.

I see, thanks for the information!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants