Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change or document AR_compound low scoring compound penalty #107

Open
dnil opened this issue Nov 28, 2022 · 4 comments
Open

Change or document AR_compound low scoring compound penalty #107

dnil opened this issue Nov 28, 2022 · 4 comments
Labels

Comments

@dnil
Copy link
Collaborator

dnil commented Nov 28, 2022

The hard coded -6 rank score penalty incurred by AR_comps with only low scoring (arbitrarily hard coded as score 9) variants is not reflected in the rankResults string exported explaining the rank results. It would not hurt to 1) figure out a way to solve the signal-noise of AR_comp without this penalty - it hits very differently in singletons vs trios 2) make it a part of the score model 3) make it appear in the rankResults.

@dnil
Copy link
Collaborator Author

dnil commented Aug 19, 2024

One more case of this https://scout.scilifelab.se/cust002/F0060093/6f7843d6fe355b956031e6aa5664bad7 from @annhamm. In general it is a weakness of the scoring model, and fixing it will allow analysts to "stop" searching at a higher score, giving shorter analysis time. Most false negatives among singletons for score thresholds were found to be caused by this particular flag. A recalibration of trio scores will be needed after changing it, but perhaps not dramatically as AR_comp is a very common occurrence in singletons.

@dnil dnil added the Task label Oct 24, 2024
@dnil
Copy link
Collaborator Author

dnil commented Oct 24, 2024

This has now gotten a lot easier in genmod 3.9, thanks to #138. One might say genmod is off the hook even, and move this to a pipeline. Should we say nf-core/raredisease @jemten and @ramprasadn? This of course goes for @fellen31 and @josefinelantz / @mathiasbio as well, but their models are perhaps not so final yet anyway.

@mathiasbio
Copy link

Hi @dnil ! Very slow response here, but how difficult would it be to activate this AR_compound function in genmod for cancer? I don't think we're using genmod this way at the moment but only looking at the variants individually. Is this just a manner of turning on some flag for genmod whereupon it would look at variants across genes and increasing the scores of variants if there are other disruptive variants in the same gene?

@dnil
Copy link
Collaborator Author

dnil commented Nov 14, 2024

Thank you for thinking of this - to me, it is slightly off topic here? I answered in one of the original issues instead: Clinical-Genomics/BALSAMIC#596.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants