From 840874e2d25719d379180d2bd68712ca399887b1 Mon Sep 17 00:00:00 2001 From: seallard Date: Thu, 14 Dec 2023 11:30:20 +0100 Subject: [PATCH 1/2] Do not modify set while iterating over it --- cg/meta/workflow/analysis.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/cg/meta/workflow/analysis.py b/cg/meta/workflow/analysis.py index f067e63944..ad50e2d205 100644 --- a/cg/meta/workflow/analysis.py +++ b/cg/meta/workflow/analysis.py @@ -31,10 +31,12 @@ def add_gene_panel_combo(default_panels: set[str]) -> set[str]: """Add gene panels combinations for gene panels being part of gene panel combination and return updated gene panels.""" - all_panels = default_panels + all_panels = default_panels.copy() + additional_panels = set() for panel in default_panels: if panel in GenePanelCombo.COMBO_1: - all_panels |= GenePanelCombo.COMBO_1.get(panel) + additional_panels |= GenePanelCombo.COMBO_1.get(panel) + all_panels |= additional_panels return all_panels From fdb5c577ba3d9c19cea72a1a058cf63400b4f7d7 Mon Sep 17 00:00:00 2001 From: seallard Date: Thu, 14 Dec 2023 11:39:47 +0100 Subject: [PATCH 2/2] Simplify --- cg/meta/workflow/analysis.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/cg/meta/workflow/analysis.py b/cg/meta/workflow/analysis.py index ad50e2d205..bbce79cfe2 100644 --- a/cg/meta/workflow/analysis.py +++ b/cg/meta/workflow/analysis.py @@ -31,13 +31,12 @@ def add_gene_panel_combo(default_panels: set[str]) -> set[str]: """Add gene panels combinations for gene panels being part of gene panel combination and return updated gene panels.""" - all_panels = default_panels.copy() additional_panels = set() for panel in default_panels: if panel in GenePanelCombo.COMBO_1: additional_panels |= GenePanelCombo.COMBO_1.get(panel) - all_panels |= additional_panels - return all_panels + default_panels |= additional_panels + return default_panels class AnalysisAPI(MetaAPI):