From 93b544864b07afb430c66b635ef26642f6ee2250 Mon Sep 17 00:00:00 2001 From: eliott Date: Wed, 22 Jan 2025 10:50:15 +0100 Subject: [PATCH] Refactor contains_only_existing_samples to accept OrderWithCases and update get_ticket_status logic --- cg/meta/orders/utils.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/cg/meta/orders/utils.py b/cg/meta/orders/utils.py index e344dacc51..66ffd36c3e 100644 --- a/cg/meta/orders/utils.py +++ b/cg/meta/orders/utils.py @@ -29,7 +29,7 @@ def get_ticket_tags(order: Order, order_type: OrderType) -> list[str]: return tags -def contains_only_existing_samples(order: Order) -> bool: +def contains_only_existing_samples(order: OrderWithCases) -> bool: """Check if the order contains only existing samples""" for enumerated_case in order.enumerated_cases: @@ -41,7 +41,7 @@ def contains_only_existing_samples(order: Order) -> bool: def get_ticket_status(order: Order) -> int: """Get the ticket status based on the order""" - - if contains_only_existing_samples(order=order): - return Status.OPEN + if isinstance(order, OrderWithCases): + if contains_only_existing_samples(order=order): + return Status.OPEN return Status.PENDING