From 0092303046bcac46c02f1f095ddb0fcecd6fba45 Mon Sep 17 00:00:00 2001 From: eliott Date: Tue, 21 Jan 2025 14:37:15 +0100 Subject: [PATCH] Rename order data check function and improve tag assignment logic --- cg/meta/orders/utils.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/cg/meta/orders/utils.py b/cg/meta/orders/utils.py index 97542c587c..bb2e45cd0e 100644 --- a/cg/meta/orders/utils.py +++ b/cg/meta/orders/utils.py @@ -5,7 +5,7 @@ from cg.services.orders.validation.models.order_with_cases import OrderWithCases -def does_order_contain_existing_data(order: OrderWithCases) -> bool: +def contains_existing_data(order: OrderWithCases) -> bool: """Check if the order contains any existing data""" for enumerated_case in order.enumerated_cases: @@ -21,7 +21,8 @@ def get_ticket_tags(order: Order, order_type: OrderType) -> list[str]: tags: list[str] = [] tags.append(ORDER_TYPE_WORKFLOW_MAP[order_type]) - if does_order_contain_existing_data(order=order): - tags.append("existing-data") + if isinstance(order, OrderWithCases): + if contains_existing_data(order=order): + tags.append("existing-data") return tags