Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ruff to dbt-clickhouse #391

Open
jpelletiPL opened this issue Nov 21, 2024 · 0 comments
Open

Adding ruff to dbt-clickhouse #391

jpelletiPL opened this issue Nov 21, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@jpelletiPL
Copy link

jpelletiPL commented Nov 21, 2024

Is your feature request related to a problem? Please describe.
My feature request is related to #369 (comment)

We have some linting issue on here that I was planning to fix, but there seems to be differences between coding styles from contributors, and I think a global linter could help having a uniform codebase

Describe the solution you'd like
I wanting to suggest replacing black and isort with ruff, we could just run it before submitting a PR and all the code would follow the same standard for everyone

Describe alternatives you've considered
I have considered using black and isort because it is already used in the project, but ruff is faster and more versatile overall

@jpelletiPL jpelletiPL added the enhancement New feature or request label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant