Bug in the vector rotation operator #3744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need more tests |
|
Can we add a test that uses |
glwagner
reviewed
Aug 28, 2024
test/test_cubed_spheres.jl
Outdated
| u = XFaceField(grid) | ||
| v = YFaceField(grid) | ||
|
|
||
| # Purely zonal flow. |
There was a problem hiding this comment.
right, it's in the extrinsic frame. I have changed the comment
|
Perhaps we don't have this, but can we rotate a |
glwagner
approved these changes
Aug 28, 2024
glwagner
reviewed
Aug 29, 2024
| @test all(sic_model.velocities.v.data[i, j, :] .≈ per_model[i, j].velocities.v.data[1, 1, :]) | ||
| @test all(sic_model.tracers.c.data[i, j, :] .≈ per_model[i, j].tracers.c.data[1, 1, :]) | ||
| end | ||
|
|
There was a problem hiding this comment.
was this sent to the wrong PR?
There was a problem hiding this comment.
yeah this was meant to be in #3741. I have moved it there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The meridional velocity had the wrong sign in the vector rotation operator for switching from extrinsic to intrinsic coordinates in an
OrthogonalSphericalShellGrid.The test was also poorly designed (my bad) and conspired to hide the bug. This PR should fix the rotation and update the test to make sure everything is correct.