Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test N-tuple MultipleForcings and make them work on the GPU #3743

Merged
merged 5 commits into from
Aug 27, 2024
Merged

Test N-tuple MultipleForcings and make them work on the GPU #3743

merged 5 commits into from
Aug 27, 2024

Conversation

ali-ramadhan
Copy link
Member

Resolves #3736

@glwagner
Copy link
Member

Should also add something like

regularize_forcing(mf::MultipleForcings, args...) = regularize_forcing(mf.forcings, args...)

so that users can write u = MultipleForcings(f1, f2)?

@ali-ramadhan
Copy link
Member Author

Added with tests! Should we export MultipleForcings?

@glwagner
Copy link
Member

Added with tests! Should we export MultipleForcings?

Maybe we don't need to since tupling is the "official" API?

@ali-ramadhan ali-ramadhan merged commit 93cf3e9 into main Aug 27, 2024
46 checks passed
@ali-ramadhan ali-ramadhan deleted the ali/fix-multiple-forcings branch August 27, 2024 23:50
@glwagner
Copy link
Member

thanks @ali-ramadhan !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glwagner glwagner glwagner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when trying to use MultipleForcings
2 participants
@ali-ramadhan @glwagner