Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in interpolate!(target_fts::FieldTimeSeries, source_fts::FieldTimeSeries)? #3731

Closed
navidcy opened this issue Aug 26, 2024 · 7 comments · Fixed by #3733
Closed

Bug in interpolate!(target_fts::FieldTimeSeries, source_fts::FieldTimeSeries)? #3731

navidcy opened this issue Aug 26, 2024 · 7 comments · Fixed by #3733
Labels
bug 🐞 Even a perfect program still has bugs

Comments

@navidcy
Copy link
Collaborator

navidcy commented Aug 26, 2024 •
edited
Loading

Seems that there is a bug here?

Oceananigans.jl/src/OutputReaders/field_time_series_indexing.jl

Line 205 in 5218acd

target_fts.data, target_grid, target_location, target_times,

target_times is never defined but used as an arg in the kernel?

This produces the error in the ClimaOcean CI; see https://buildkite.com/clima/climaocean-ci/builds/1264#01918d21-30e8-4d9c-9ee8-a220eb16eb28/202-514

cc @simone-silvestri
@navidcy navidcy added the bug 🐞 Even a perfect program still has bugs label Aug 26, 2024
@navidcy navidcy mentioned this issue Aug 26, 2024
Open
@glwagner
Copy link
Member

Shouldn't that be target_times = target_fts.times ?

@glwagner
Copy link
Member

Can you run the function (produce a bug with code rather than merely by reading it)? Is there a test?

@navidcy
Copy link
Collaborator Author

navidcy commented Aug 26, 2024 •
edited
Loading

The tests in ClimaOcean run the function and produced a bug. I linked the log above.

I can try to create an MWE if it helps.

@navidcy
Copy link
Collaborator Author

navidcy commented Aug 26, 2024

#3723 seems to have deleted target_times

@simone-silvestri simone-silvestri mentioned this issue Aug 26, 2024
Merged
@glwagner
Copy link
Member

Wouldn't the MWE be a one line function? We also need to test it here

@simone-silvestri
Copy link
Collaborator

#3733 introduces a very simple test for interpolation on field time series (testing trivial interpolation)

@glwagner
Copy link
Member

good

simone-silvestri added a commit that referenced this issue Aug 26, 2024
@simone-silvestri @navidcy
Bugfix for #3731 (#3733)
29c8115 
* add the bugfix

* bump patch release

* add interpolate

* fix tests

---------

Co-authored-by: Navid C. Constantinou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐞 Even a perfect program still has bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix for #3731 CliMA/Oceananigans.jl
3 participants
@navidcy @glwagner @simone-silvestri