You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some of the docs still include the background viscosity in the description of Smagorinsky-Lilly. Maybe you're purposefully keeping the "Physics" different than the "Model," but if it's a typo, these are the two places it's the old version:
Maybe you're purposefully keeping the "Physics" different than the "Model,"
I don't think so!
Previously we made the argument that the background viscosity is not part of the "eddy viscosity", conceptually. And of course as you point out that's not how its implemented currently either. So I agree this should be fixed.
This description in the model setup is also a bit misleading, or, at least, unclear.
Totally, this is wrong, there is no background viscosity of diffusivity when using SmagorinskyLilly either settable or by default.
Some of the docs still include the background viscosity in the description of Smagorinsky-Lilly. Maybe you're purposefully keeping the "Physics" different than the "Model," but if it's a typo, these are the two places it's the old version:
Oceananigans.jl/docs/src/physics/turbulence_closures.md
Lines 75 to 81 in 738d172
Oceananigans.jl/docs/src/physics/turbulence_closures.md
Lines 104 to 109 in 738d172
This description in the model setup is also a bit misleading, or, at least, unclear.
Oceananigans.jl/docs/src/model_setup/turbulent_diffusivity_closures_and_les_models.md
Lines 71 to 72 in 738d172
The text was updated successfully, but these errors were encountered: