ECCO Restoring for OMIP simulations #89
Conversation
| @@ -116,7 +117,7 @@ function regrid_bathymetry(target_grid; | |||
| close(dataset) | |||
|
|
|||
| # Diagnose target grid information | |||
| arch = architecture(target_grid) | |||
| arch = child_architecture(architecture(target_grid)) | |||
There was a problem hiding this comment.
| arch = child_architecture(architecture(target_grid)) | |
| arch = child_architecture(target_grid) |
There was a problem hiding this comment.
I ll do a PR in Oceananigans to allow this and correct it in a late PR
| # The whole range of dates in the different dataset versions | ||
| all_ecco_dates(::ECCO4Monthly) = DateTimeProlepticGregorian(1992, 1, 1) : Month(1) : DateTimeProlepticGregorian(2023, 12, 1) | ||
| all_ecco_dates(::ECCO2Monthly) = DateTimeProlepticGregorian(1992, 1, 1) : Month(1) : DateTimeProlepticGregorian(2023, 12, 1) | ||
| all_ecco_dates(::ECCO2Daily) = DateTimeProlepticGregorian(1992, 1, 4) : Day(1) : DateTimeProlepticGregorian(2023, 12, 31) |
There was a problem hiding this comment.
for clarify, you probably want to define things like
const ECCO2_final_time = DateTimeProlepticGregorian(2023, 12, 1)or something. And put them near the definition of the struct ECCO2Monthly for example. Because these things will change in the future presumably.
|
@navidcy there is some problems with the docs (the operation is cancelled for some kind of reason). Can you take a look to see what is happening? |
|
Maybe change |
At the moment, ECCO_USERNAME and ECCO_PASSWORD are set on the clima cluster as environment variables. So maybe, after this PR we can open another PR that changes these names in the code and in the setup (in the secret tokens and the clima cluster) |
Co-authored-by: Gregory L. Wagner <[email protected]>
|
Given that the tests pass I will merge this PR. |
This PR reworks the whole ECCO2 module, renaming it to ECCO since it adds three different "versions"
It also introduces an
ECCO_field_time_serieswith its associatedECCONetCDFbackendand anECCO_restoring_forcingon top of that to restore prognostic variables to ecco data.The ECCO data is downloaded from the ecco website by providing an
ECCO_USERNAMEand anECCO_PASSWORDas environmental variablesTODOs: