Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NearGlobalSimulations #72

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Conversation

glwagner
Copy link
Member

@glwagner glwagner commented Apr 1, 2024

These are basically unused. @simone-silvestri has been using different code for his setups anyways. Also, we don't want to use these in the future, since we will want to use OceanSeaIceModel.

Closes #11

@navidcy navidcy self-requested a review April 2, 2024 09:59
Copy link
Collaborator

@simone-silvestri simone-silvestri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice cleanup

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (de17150) to head (bb1513c).

Additional details and impacted files
@@          Coverage Diff           @@
##            main     #72    +/-   ##
======================================
  Coverage   0.00%   0.00%            
======================================
  Files         14      10     -4     
  Lines        765     428   -337     
======================================
+ Misses       765     428   -337     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@navidcy navidcy merged commit dae2975 into main Apr 2, 2024
9 checks passed
@navidcy navidcy deleted the glw/rm-near-global-simulations branch April 2, 2024 10:50
navidcy added a commit that referenced this pull request Apr 2, 2024
breaking change in #72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OceanArtifacts.jl points to a branch
3 participants