Simplify callbacks #1121
Open
Simplify callbacks #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sbozzolo
force-pushed
the
gb/callbacks
branch
from
9d7609b to
b123fca
Compare
juliasloan25
approved these changes
Dec 12, 2024
config/ci_configs/amip_coarse_ft64_hourly_checkpoints_restart.yml
Outdated
Show resolved
Hide resolved
Sbozzolo
force-pushed
the
gb/callbacks
branch
4 times, most recently
from
0c8ea8a to
d08ab62
Compare
This commit removes most of the callback infrastructure in `ClimaCoupler` in favor of a simpler one that leverages what we already use in other packages. The current "schedule" system is the one from `ClimaDiagnostics`, but the plan is to move it to `ClimaUtilities` as part of the work towards the integer time. Using the schedule system from `ClimaDiagnostics` eliminated the need for keeping track of the first day of the month. I also updated the checkpointing callbacks so that they can run with frequencies that are smaller than one hour.
Sbozzolo
force-pushed
the
gb/callbacks
branch
from
d08ab62 to
de9940a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes most of the callback infrastructure in
ClimaCouplerin favor of a simpler one that leverages what we already use in other packages. The current "schedule" system is the one fromClimaDiagnostics, but the plan is to move it toClimaUtilitiesas part of the work towards the integer time.Using the schedule system from
ClimaDiagnosticseliminated the need for keeping track of the first day of the month.I also updated the checkpointing callbacks so that they can run with frequencies that are smaller than one hour.