Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add float-type constructor for ClimaAtmosParameters #3481

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nefrathenrici
Copy link
Member

@nefrathenrici nefrathenrici commented Dec 12, 2024

This PR allows us to create a minimal parameter set for all model configurations using FT as input.

create_parameter_set has been replaced with direct ClimaAtmosParameters constructors which are not dependent on the AtmosConfig, but we should not see any simulation changes.

ClimaAtmosParameters (CAP) now contains parameters for all configurations to prevent the use of parsed_args. CAP already contained parameters that were unused by certain configurations, such as RRTMGP parameters. This primarily affects the microphysics parameters - both 0m and 1m params are now stored regardless of config. This PR touches a lot of files because the access to specific microphysics parameters structs in tendencies had to be changed.

The main method is ClimaAtmosParameters(toml_dict::TD, dt = nothing). If dt is passed in, it is used to override the precipitation_timescale used in microphysics. Since the config key override_precip_timescale is no longer used it has been removed.

Other constructors are available, which end up calling the toml_dict method:

  • ClimaAtmosParameters(config::AtmosConfig)
  • ClimaAtmosParameters(::Type{FT}, dt = nothing)

This PR also removes water_params, they are unused

@nefrathenrici nefrathenrici force-pushed the ne/params branch 2 times, most recently from 0fcae94 to 9ffa61c Compare December 13, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant