Adds Soares test case with smooth detrainment #3473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds soares test case clima formatter replace detrainment limiter with default cleans up ci plots Increase reference counter for buildkite job
Julians42
force-pushed
the
j/soares_pr
branch
from
ab211f0 to
dddf648
Compare
szy21
reviewed
Dec 10, 2024
| edmfx_sgs_diffusive_flux: true | ||
| edmfx_nh_pressure: true | ||
| edmfx_filter: true | ||
| prognostic_tke: false # should we set this as true or false? |
There was a problem hiding this comment.
What happens if it is set to true?
| perturb_initstate: false | ||
| dt: "5secs" | ||
| t_end: "8hours" | ||
| dt_save_state_to_disk: "14hours" |
There was a problem hiding this comment.
Suggested change
| dt_save_state_to_disk: "14hours" |
(14 hours is longer than t_end, so you can just remove this line. The default is Inf.)
| artifact_paths: "prognostic_edmfx_soares_column/output_active/*" | ||
| agents: | ||
| slurm_mem: 20GB | ||
| soft_fail: true |
There was a problem hiding this comment.
You don't need to change the ref counter if you don't add a reproducibility test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adds soares test case following Soares 2004 paper that uses smooth area detrainment closure.
To-do
Content