Add deep convection to gcm-driven SCM setup #3364
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costachris
force-pushed
the
cc/add_deep_conv_gcmdriven
branch
from
0ff34b7 to
7733cb7
Compare
costachris
force-pushed
the
cc/add_deep_conv_gcmdriven
branch
from
7733cb7 to
0341135
Compare
|
The parameters change looks good to me. Gabriele can take a look at the code change. |
Sbozzolo
reviewed
Oct 5, 2024
costachris
force-pushed
the
cc/add_deep_conv_gcmdriven
branch
from
0341135 to
990f3b1
Compare
Sbozzolo
reviewed
Oct 6, 2024
There was a problem hiding this comment.
Code looks good (altough, I think that it is more efficient to dispatch over the first argument). Could you please add some documentation, docstrings, and expand upon what the config external_forcing_type is?
Your help message for external_forcing_type is "External forcing type", which doesn't teach much
|
Actually, I think we should add these time scales to parameters instead of having a type. No need to change it now, but whoever uses it or changes it again for other types (e.g. reanalysis) should use parameters instead I think. |
costachris
commented
Oct 7, 2024
costachris
force-pushed
the
cc/add_deep_conv_gcmdriven
branch
from
990f3b1 to
67b0d4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add relaxation timescale for deep convection in gcm-driven SCM setup