Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn NOGW tendency into a callback #3434

Open
nefrathenrici opened this issue Nov 13, 2024 · 3 comments
Open

Turn NOGW tendency into a callback #3434

nefrathenrici opened this issue Nov 13, 2024 · 3 comments
Assignees

Comments

@nefrathenrici
Copy link
Member

Non-orographic gravity wave tendency should not be called every timestep, it should be a callback instead.

We should also provide the u_forcing and v_forcing quantities as diagnostics

@charleskawczynski
Copy link
Member

I'm just curious, why is this?

@nefrathenrici
Copy link
Member Author

nefrathenrici commented Nov 13, 2024

These are some minor improvements to take care of before updating the parameterization to match the GFDL code. This is not high priority, but I plan on getting to it next week.

@nefrathenrici nefrathenrici self-assigned this Nov 13, 2024
@szy21
Copy link
Member

szy21 commented Nov 19, 2024

I'm just curious, why is this?

Adding nonorographic gravity wave in AMIP results in ~20% reduction in SYPD. We can further improve the performance, but we don't really need gravity wave every time step, so turning it into a callback and calling it e.g. every hour is a straightforward solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants