Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logical inconsistency in the use of decorrelate in the Emulator construction? #269

Open
bielim opened this issue Dec 22, 2023 · 0 comments

Comments

@bielim
Copy link
Contributor

bielim commented Dec 22, 2023

There may be a logical inconsistency in Emulator.jl: In the Emulator object constructor, when decorrelate is set to true but machine_learning_tool is a VectorRandomFeatureInterface, there is no error, even though the comment suggests that decorrelation is not performed for vector RF. Is this the intended behavior?
(In the current implementation, the exception for is only thrown when decorrelate is false and the machine learning tool is not a vector RF).

    
    # [3.] Decorrelating the outputs, **not performed for vector RF**
    if decorrelate
        [...]
    else
        if decorrelate || !isa(machine_learning_tool, VectorRandomFeatureInterface)
            throw(ArgumentError("$machine_learning_tool is incompatible with option Emulator(...,decorrelate = false)"))
        end
        [...]
    end


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant