You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There may be a logical inconsistency in Emulator.jl: In the Emulator object constructor, when decorrelate is set to true but machine_learning_tool is a VectorRandomFeatureInterface, there is no error, even though the comment suggests that decorrelation is not performed for vector RF. Is this the intended behavior?
(In the current implementation, the exception for is only thrown when decorrelate is false and the machine learning tool is not a vector RF).
# [3.] Decorrelating the outputs, **not performed for vector RF**if decorrelate
[...]
elseif decorrelate ||!isa(machine_learning_tool, VectorRandomFeatureInterface)
throw(ArgumentError("$machine_learning_tool is incompatible with option Emulator(...,decorrelate = false)"))
end
[...]
end
The text was updated successfully, but these errors were encountered:
There may be a logical inconsistency in
Emulator.jl
: In theEmulator
object constructor, whendecorrelate
is set to true butmachine_learning_tool
is aVectorRandomFeatureInterface
, there is no error, even though the comment suggests that decorrelation is not performed for vector RF. Is this the intended behavior?(In the current implementation, the exception for is only thrown when decorrelate is false and the machine learning tool is not a vector RF).
The text was updated successfully, but these errors were encountered: