Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stepsize check too brittle #169

Open
odunbar opened this issue Jul 8, 2022 · 0 comments
Open

stepsize check too brittle #169

odunbar opened this issue Jul 8, 2022 · 0 comments
Assignees
@tsj5

Comments

@odunbar
Copy link
Collaborator

odunbar commented Jul 8, 2022

CalibrateEmulateSample.jl/test/MarkovChainMonteCarlo/runtests.jl

Line 146 in 245b264

@test isapprox(new_step, 0.25; atol = 0.1)

Checks such as this break, when a stepsize "one too small" which selects 0.25/2 = 0.125 or "one too big" which will be 0.25*2 = 0.5, this occasionally happens due to the randomness (succeeds on rerun of test) and should be relaxed
@tsj5 tsj5 mentioned this issue Sep 2, 2022
Merged
10 tasks
@odunbar odunbar mentioned this issue Oct 1, 2022
Merged
bors bot added a commit that referenced this issue Oct 1, 2022
@bors @odunbar
Merge #188
d6543d5 
188: remove manifest, fix mcmc performance r=odunbar a=odunbar

## Purpose 
Removes manifest from project. Doing so caused performance hit, changed offending lines to regain performance.

## Content
- Fixes #184 
- Fixes #182 
- soft-fix for #169
- updates EKP compat to 0.13

Co-authored-by: odunbar <[email protected]>
bors bot added a commit that referenced this issue Oct 1, 2022
@bors @odunbar
Merge #188
8d87f44 
188: remove manifest, fix mcmc performance r=odunbar a=odunbar

## Purpose 
Removes manifest from project. Doing so caused performance hit, changed offending lines to regain performance.

## Content
- Fixes #184 
- Fixes #182 
- soft-fix for #169
- updates EKP compat to 0.13

Co-authored-by: odunbar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsj5 tsj5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tsj5 @odunbar