Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrow keys dont work instantly when --default_widget_type is set to CPU #1341

Closed
1 task done
ShalokShalom opened this issue Nov 30, 2023 · 7 comments
Closed
1 task done

Comments

@ShalokShalom
Copy link

Checklist

What operating system and version are you using?

NixOS

What architecture are you using?

x86_64 / AMD64

What terminal(s) are you running bottom on?

Konsole

Are you using ZFS?

No

What version of bottom are you running?

0.9.1

How did you install bottom?

NixOS

Describe the issue

Setting the default widget style to CPU lets me not use the arrow keys on start
Clicking on the widget does allow me to use the arrow keys

What is the expected behaviour?

I start the app with --default_widget_type cpu and can immediately move with the arrow keys between the selections

What is the actual behaviour?

Arrow keys show no effect

How can we reproduce this?

  1. btm --dot_marker --group --rate 500 --default_widget_type cpu --color nord
  2. Press arrow key down to select "AVG"
  3. Not working
  4. Click on the widget
  5. Press the arrow key
  6. See its working

Additional information

Thanks a lot 🥳

@ShalokShalom ShalokShalom added the bug Something isn't working the way that is expected. label Nov 30, 2023
@ClementTsang
Copy link
Owner

Does this occur with the newest stable release (0.9.6)?

@ClementTsang
Copy link
Owner

ClementTsang commented Nov 30, 2023

Just tested it - this is technically correct behaviour, you would have the same behaviour if you started on the process widget and selected the graph part of the CPU widget, which is what is selected by default if you do --default_widget_type cpu.

That said, I honestly don't remember why I made them disconnected - might have been for consistency since things like the process widget treat things like the search and sort "subwidgets" as separate widgets from the main process widget.

@ShalokShalom
Copy link
Author

I suggest a simple line, that transitions one into the other, after the startup
Ideally, it would also save the position past closing the app, while I guess thats a separate issue.

Thanks

@ClementTsang
Copy link
Owner

ClementTsang commented Nov 30, 2023

I suggest a simple line, that transitions one into the other, after the startup

Sorry, not exactly sure what you mean by this - do you mean like combining the two with a connector? I guess that's doable, though I don't know if I want to do that.

As for saving the position between invocations, yeah that seems reasonable to add at some point as an option. (EDIT: filed #1345)

@ShalokShalom
Copy link
Author

As far as I understand, starts the app now in a state, in which it is impossible to move the cursor by arrow keys

And I understand, that there is another state, which allows that

Why not simply transition from one state into the other automatically?
At startup?

@ClementTsang
Copy link
Owner

🤷 I don't really feel like that's a necessity, and I would rather address the crux of your issue (that you wanted to select the average CPU by default).

@ClementTsang ClementTsang removed the bug Something isn't working the way that is expected. label Dec 3, 2023
@ClementTsang
Copy link
Owner

Closing as this is not a bug, and in favour of #1350.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants