From 1eb214e5411ba30405baa7c16b7f4e0a27fe071a Mon Sep 17 00:00:00 2001 From: Dor Harpaz Date: Thu, 24 Apr 2025 11:43:09 +0300 Subject: [PATCH 1/2] delete me --- algorithms/bernstein_vazirani/bernstein_vazirani.ipynb | 2 +- tests/notebooks/test_bernstein_vazirani.py | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/algorithms/bernstein_vazirani/bernstein_vazirani.ipynb b/algorithms/bernstein_vazirani/bernstein_vazirani.ipynb index 0f680e7ef..b22e4b907 100644 --- a/algorithms/bernstein_vazirani/bernstein_vazirani.ipynb +++ b/algorithms/bernstein_vazirani/bernstein_vazirani.ipynb @@ -208,7 +208,7 @@ "id": "2e210edf-f2ce-478a-9118-655d1d64f0cc", "metadata": {}, "source": [ - "We can now visualize the circuit:" + "We can now visualize the circuit: " ] }, { diff --git a/tests/notebooks/test_bernstein_vazirani.py b/tests/notebooks/test_bernstein_vazirani.py index 89418dc3b..7aca25fb5 100644 --- a/tests/notebooks/test_bernstein_vazirani.py +++ b/tests/notebooks/test_bernstein_vazirani.py @@ -11,6 +11,9 @@ def test_notebook(tb: TestbookNotebookClient) -> None: # test models validate_quantum_model(tb.ref("qmod")) # test quantum programs + a = tb.ref("qprog") + assert type(a) is None, f"{type(a)=} ,,, {tb.ref('type(qprog)')=}" + validate_quantum_program_size( tb.ref("qprog"), expected_width=6, From 522abcad779fc70873913151911070184387dcd3 Mon Sep 17 00:00:00 2001 From: Dor Harpaz Date: Thu, 24 Apr 2025 11:56:57 +0300 Subject: [PATCH 2/2] maybe fix --- tests/notebooks/test_bernstein_vazirani.py | 4 +--- tests/utils_for_testbook.py | 10 ++++------ 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/tests/notebooks/test_bernstein_vazirani.py b/tests/notebooks/test_bernstein_vazirani.py index 7aca25fb5..1ef4850bd 100644 --- a/tests/notebooks/test_bernstein_vazirani.py +++ b/tests/notebooks/test_bernstein_vazirani.py @@ -11,11 +11,9 @@ def test_notebook(tb: TestbookNotebookClient) -> None: # test models validate_quantum_model(tb.ref("qmod")) # test quantum programs - a = tb.ref("qprog") - assert type(a) is None, f"{type(a)=} ,,, {tb.ref('type(qprog)')=}" validate_quantum_program_size( - tb.ref("qprog"), + tb.ref_numpy("qprog"), expected_width=6, expected_depth=5, ) diff --git a/tests/utils_for_testbook.py b/tests/utils_for_testbook.py index 533f1ac23..529f9e6cc 100644 --- a/tests/utils_for_testbook.py +++ b/tests/utils_for_testbook.py @@ -142,23 +142,21 @@ def validate_quantum_model(model: str) -> None: def validate_quantum_program_size( - quantum_program: str, + qp: QuantumProgram, expected_width: int | None = None, expected_depth: int | None = None, - compare_to: str | None = None, + compare_to: QuantumProgram | None = None, allow_zero_size: bool = False, ) -> None: if compare_to is not None: - other_qp = QuantumProgram.model_validate_json(quantum_program) + other_qp = compare_to other_width = other_qp.data.width assert other_qp.transpiled_circuit is not None # for mypy other_depth = other_qp.transpiled_circuit.depth - return validate_quantum_program_size(quantum_program, other_width, other_depth) - - qp = QuantumProgram.model_validate_json(quantum_program) + return validate_quantum_program_size(qp, other_width, other_depth) actual_width = qp.data.width if expected_width is not None: