Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate yubikey pages #1193

Merged
merged 5 commits into from
Oct 4, 2023
Merged

Consolidate yubikey pages #1193

merged 5 commits into from
Oct 4, 2023

Conversation

sfmcgee
Copy link
Contributor

@sfmcgee sfmcgee commented Jun 12, 2023

Consolidate all Yubikey content under one page.


📚 Documentation preview 📚: https://civicactions-handbook--1193.org.readthedocs.build/en/1193/

Copy link
Member

@openprivacy openprivacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love to see movement on this. Made a few change requests.

common-practices-tools/security/README.md Show resolved Hide resolved
common-practices-tools/security/yubikey.md Outdated Show resolved Hide resolved
common-practices-tools/security/yubikey.md Outdated Show resolved Hide resolved
common-practices-tools/security/yubikey.md Outdated Show resolved Hide resolved
common-practices-tools/security/yubikey.md Outdated Show resolved Hide resolved
common-practices-tools/security/yubikey.md Outdated Show resolved Hide resolved
common-practices-tools/security/yubikey.md Outdated Show resolved Hide resolved

_tbd..._

##### Away detection ideas
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can become a two-octothorp (##) top-level section

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is specific to Mac or Linux users, so it's a sub-heading under that.

sudo apt-get install yubikey-neo-manager yubikey-personalization yubikey-personalization-gui
```

#### Locking your Machine with YubiKey
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can become a two-octothorp (##) top-level section

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is specific to Mac or Linux users, so it's a sub-heading under that.

@sfmcgee sfmcgee force-pushed the smcgee-consolidate-yubikey-pages branch from 092bebb to 8b9f9d8 Compare August 22, 2023 23:45
@sfmcgee sfmcgee changed the title DRAFT: smcgee-consolidate-yubikey-pages - consolidate yubikey pages Consolidate yubikey pages Aug 22, 2023
@sfmcgee
Copy link
Contributor Author

sfmcgee commented Aug 22, 2023

Ok @openprivacy , I incorporated all of your suggested changes, except for the octothorpe header changes, since those sections only apply to Linux or MacOS. Let me know your thoughts, thanks!

Copy link
Member

@openprivacy openprivacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit. Thanks again for all your work on this!

<!-- prettier-ignore-start -->

- My Vault -> Account Settings -> Multifactor Options
- Set up one free option (e.g., [Google Authenticator](https://support.google.com/accounts/answer/1066447?hl=en)) - this is a useful backup
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On https://guidebook.civicactions.com/en/latest/common-practices-tools/security/#multi-factor-authenticators-mfa we say:

Note that Google Authenticator is no longer recommended as it does not support encrypted cloud backup.

...which I believe is still the case. (Should also say we prefer the work-alike Authy.)
Can we switch this to "Authy" and also make the change on line 60 below?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found: https://security.googleblog.com/2023/04/google-authenticator-now-supports.html -- so maybe should remove that line from the Awareness and Tools page... though I'm a bit uneasy (for some reason) about the passwords becoming part of a Google account. Thoughts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this @openprivacy - I removed the note about Google Authenticator not being recommended, since it now supports cloud backup. But we won't list it as one of the recommended 3 that are currently there (LP Authenticator, Authy & Yubikey). I also added Lastpass Authenticator to row 35 of the yubikey.md page above, in addition to Google Authenticator. I think as long as users don't store their actual passwords in the Google Password Manager/Chrome, then backing up the authenticator app to Google doesn't add much risk. An adversary would still need their password. I haven't heard of any system compromises due to getting access to an authenticator app's backup info.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the conversation in the internal security TEM, add a note about not leaving your Yubikey in your laptop if you are working away from home and step away from it (Starbucks bathroom scenario).

@sfmcgee sfmcgee force-pushed the smcgee-consolidate-yubikey-pages branch from 72105cc to 8d18d6f Compare August 31, 2023 23:03
Copy link
Member

@openprivacy openprivacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good - thankl you for your changes and general work on this.

@sfmcgee sfmcgee force-pushed the smcgee-consolidate-yubikey-pages branch from f616e61 to 1109968 Compare October 4, 2023 18:32
@sfmcgee sfmcgee marked this pull request as ready for review October 4, 2023 18:33
@sfmcgee sfmcgee requested review from a team as code owners October 4, 2023 18:33
Copy link
Member

@openprivacy openprivacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have followed the updates - this is much needed work to clean up how we use Yubikeys. Thanks!

@sfmcgee sfmcgee force-pushed the smcgee-consolidate-yubikey-pages branch from 6ee64f6 to 70d1710 Compare October 4, 2023 19:07
@sfmcgee sfmcgee merged commit 826909c into master Oct 4, 2023
9 checks passed
@sfmcgee sfmcgee deleted the smcgee-consolidate-yubikey-pages branch October 4, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants