Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
swirtSJW authored Oct 17, 2024
1 parent 3613011 commit be7e90e
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions common-practices-tools/contribution/contrib-first.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
# Contrib First

Whenever we are building something that could be of use to more than just one project or client, we build it as contributed work first.
Whenever we are building something that could be of use to more than one project or client, we build it as contributed work first.

## Rationale for contrib first

- **Fiscal responsibility** - Building it and contributing it means that other government agencies will never have to pay to build the same thing. This helps agencies comply with Federal Source Code Policy: Achieving Efficiency, Transparency, and Innovation through Reusable and Open Source Software [OMB Memorandum M-16-21](https://obamawhitehouse.archives.gov/sites/default/files/omb/memoranda/2016/m_16_21.pdf)
- **Reusablity** - CivcActions other clients can benefit from work that was already done.
- **Security** - contributing our work to an open source project like Drupal means it it receives security coverage by the Drupal security team and the public.
- **Security** - contributing our work to an open source project like Drupal means it may receive security coverage by the Drupal security team and the public.
- **Avoiding the gift that never happens** - Clients are not typically supportive of taking working local software that was already built for them and in use by them and then paying to move or refactor that software to be open source. The benefit is too small for the cost. By building it as contributed code first, there is no extra cost.
- **Development happens in the open** - The issue are public. The commits are public. Everyone can contribute.

Expand All @@ -22,3 +22,5 @@ Whenever we are building something that could be of use to more than just one pr
- [Node Link Report](https://www.drupal.org/project/node_link_report)
- [Post API](https://www.drupal.org/project/post_api)
- [Vertex AI Search](https://www.drupal.org/project/vertex_ai_search)

See more of [CivicActions Drupal contributions](https://drupal.org/civicactions).

0 comments on commit be7e90e

Please sign in to comment.