Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If all keywords in an event are removed, no django signal and hence no n_events_changed=True is triggered #201

Open
Rikuoja opened this issue Mar 17, 2017 · 3 comments

Comments

@Rikuoja
Copy link
Contributor

Rikuoja commented Mar 17, 2017

This is most likely related to Django limitation documented in https://code.djangoproject.com/ticket/6707#comment:37 . Addressing this issue would require creating a model and custom save method for the through table.

Not to be considered a priority, as removing all keywords through the API should be rare, and event numbers will be updated accordingly when each keyword is added the next time.

@Rikuoja
Copy link
Contributor Author

Rikuoja commented Mar 17, 2017

post_clear signal is not triggered, so no help there.

@akx
Copy link
Contributor

akx commented Mar 28, 2017

Isn't this superseded by #198/#200?

@Rikuoja
Copy link
Contributor Author

Rikuoja commented Mar 28, 2017

Sadly not :/ This is a corner case that is not caught by https://github.com/City-of-Helsinki/linkedevents/blob/master/events/models.py#L501 , and post_clear doesn't trigger so useless to add it there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants